[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-163793420 @CodingCat could you close this one? We can revisit this one when moving Actor to a separate project. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-163834622 sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat closed the pull request at: https://github.com/apache/spark/pull/3984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123782737 [Test build #1169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1169/console) for PR 3984 at commit [`b020228`](https://github.com/apache/spark/commit/b0202285c077f48a2e6949005d0371ee56755f03). * This patch **fails to build**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait ActorHelper extends Logging ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123782717 [Test build #1169 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1169/consoleFull) for PR 3984 at commit [`b020228`](https://github.com/apache/spark/commit/b0202285c077f48a2e6949005d0371ee56755f03). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123690820 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123714659 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123715501 [Test build #38073 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38073/consoleFull) for PR 3984 at commit [`b020228`](https://github.com/apache/spark/commit/b0202285c077f48a2e6949005d0371ee56755f03). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123715544 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123715473 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123714661 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123715536 [Test build #38073 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38073/console) for PR 3984 at commit [`b020228`](https://github.com/apache/spark/commit/b0202285c077f48a2e6949005d0371ee56755f03). * This patch **fails to build**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait ActorHelper extends Logging ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123715470 [Test build #38072 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38072/console) for PR 3984 at commit [`22fcad0`](https://github.com/apache/spark/commit/22fcad067266f9103f3ee571aac8e7d92ce1dc79). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123715428 [Test build #38072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38072/consoleFull) for PR 3984 at commit [`22fcad0`](https://github.com/apache/spark/commit/22fcad067266f9103f3ee571aac8e7d92ce1dc79). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123927822 [Test build #38140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38140/console) for PR 3984 at commit [`30aad6e`](https://github.com/apache/spark/commit/30aad6e86f412161bf33052ba84a20cb0d839cc8). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class TrainValidationSplit(override val uid: String) extends Estimator[TrainValidationSplitModel]` * `trait ActorHelper extends Logging ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123927875 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123931811 Hi, @tdas , do you have time to review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123919203 [Test build #38138 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38138/consoleFull) for PR 3984 at commit [`d0e06da`](https://github.com/apache/spark/commit/d0e06da9ccc13aba55d07716a44f1bed6677cceb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123919392 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123920412 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123920390 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123918996 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123919014 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123919388 [Test build #38138 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38138/console) for PR 3984 at commit [`d0e06da`](https://github.com/apache/spark/commit/d0e06da9ccc13aba55d07716a44f1bed6677cceb). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class TrainValidationSplit(override val uid: String) extends Estimator[TrainValidationSplitModel]` * `trait ActorHelper extends Logging ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123920629 [Test build #38140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38140/consoleFull) for PR 3984 at commit [`30aad6e`](https://github.com/apache/spark/commit/30aad6e86f412161bf33052ba84a20cb0d839cc8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-123700266 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-103168135 [Test build #33006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33006/consoleFull) for PR 3984 at commit [`47de085`](https://github.com/apache/spark/commit/47de0857f4ecdf32a5b15560bb698b89f0ddb02f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-103167009 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-103167087 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-103200709 [Test build #33006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33006/consoleFull) for PR 3984 at commit [`47de085`](https://github.com/apache/spark/commit/47de0857f4ecdf32a5b15560bb698b89f0ddb02f). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-103200735 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33006/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-103200730 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-103215406 It's easier than I thought, the changes about RPC interface didn't touch this part @tdas might have a review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-103223268 Sorry about the delay. Will take a look once the 1.4 release craze is over. Soon. :) On Mon, May 18, 2015 at 2:20 PM, Nan Zhu notificati...@github.com wrote: It's easier than I thought, the changes about RPC interface didn't touch this part @tdas https://github.com/tdas might have a review? â Reply to this email directly or view it on GitHub https://github.com/apache/spark/pull/3984#issuecomment-103215406. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-102393174 @tdas @CodingCat what's the status on this one? looks like it needs a rebase now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-102394042 I will do it next weekas there is a significant change in the code base (Akka was gone), I will think about how to adapt it to the current master branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-75528392 sure, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-75441722 ping? @tdas do you mind take a review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-75490230 Will do as soon as I finish some stuff regarding the Spark 1.3 release. :) On Sun, Feb 22, 2015 at 7:55 AM, Nan Zhu notificati...@github.com wrote: ping? @tdas https://github.com/tdas do you mind take a review? â Reply to this email directly or view it on GitHub https://github.com/apache/spark/pull/3984#issuecomment-75441722. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-70643677 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-69567317 anyone can take a review of this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-69657239 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/3984#discussion_r22754263
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ActorReceiver.scala
---
@@ -149,43 +181,61 @@ private[streaming] class ActorReceiver[T: ClassTag](
class Supervisor extends Actor {
override val supervisorStrategy = receiverSupervisorStrategy
-val worker = context.actorOf(props, name)
-logInfo(Started receiver worker at: + worker.path)
-
-val n: AtomicInteger = new AtomicInteger(0)
-val hiccups: AtomicInteger = new AtomicInteger(0)
-
--- End diff --
supervisor is single-threaded , I don't think we have scenario where we
update concurrently
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/3984#discussion_r22754237
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ActorReceiver.scala
---
@@ -149,43 +181,61 @@ private[streaming] class ActorReceiver[T: ClassTag](
class Supervisor extends Actor {
override val supervisorStrategy = receiverSupervisorStrategy
-val worker = context.actorOf(props, name)
-logInfo(Started receiver worker at: + worker.path)
-
-val n: AtomicInteger = new AtomicInteger(0)
-val hiccups: AtomicInteger = new AtomicInteger(0)
-
--- End diff --
Why do you stop using AtomicInteger?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/3984#discussion_r22755829
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ActorReceiver.scala
---
@@ -149,43 +181,61 @@ private[streaming] class ActorReceiver[T: ClassTag](
class Supervisor extends Actor {
override val supervisorStrategy = receiverSupervisorStrategy
-val worker = context.actorOf(props, name)
-logInfo(Started receiver worker at: + worker.path)
-
-val n: AtomicInteger = new AtomicInteger(0)
-val hiccups: AtomicInteger = new AtomicInteger(0)
-
--- End diff --
I think, it's not single-threaded. Multiple threads can access to
Supervisor. Each thread couldn't access at a same time but it includes
memory-visibility problem.
Or, how about marking those vals as volatile?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/3984#discussion_r22756102
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ActorReceiver.scala
---
@@ -149,43 +181,61 @@ private[streaming] class ActorReceiver[T: ClassTag](
class Supervisor extends Actor {
override val supervisorStrategy = receiverSupervisorStrategy
-val worker = context.actorOf(props, name)
-logInfo(Started receiver worker at: + worker.path)
-
-val n: AtomicInteger = new AtomicInteger(0)
-val hiccups: AtomicInteger = new AtomicInteger(0)
-
--- End diff --
hmmm..because supervisor is implemented as an actor, n and hiccups are
maintained as the state of the actor and are only accessed via the handler of
the message... so...I don't think it can be accessed by multiple threads ...I
missed something in the code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/3984#discussion_r22756612
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ActorReceiver.scala
---
@@ -149,43 +181,61 @@ private[streaming] class ActorReceiver[T: ClassTag](
class Supervisor extends Actor {
override val supervisorStrategy = receiverSupervisorStrategy
-val worker = context.actorOf(props, name)
-logInfo(Started receiver worker at: + worker.path)
-
-val n: AtomicInteger = new AtomicInteger(0)
-val hiccups: AtomicInteger = new AtomicInteger(0)
-
--- End diff --
Correct, volatile is not necessary.
https://groups.google.com/forum/#!msg/scalaz/kFnICLFjO-4/GT_59mZLrFAJ
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/3984#discussion_r22756477
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ActorReceiver.scala
---
@@ -149,43 +181,61 @@ private[streaming] class ActorReceiver[T: ClassTag](
class Supervisor extends Actor {
override val supervisorStrategy = receiverSupervisorStrategy
-val worker = context.actorOf(props, name)
-logInfo(Started receiver worker at: + worker.path)
-
-val n: AtomicInteger = new AtomicInteger(0)
-val hiccups: AtomicInteger = new AtomicInteger(0)
-
--- End diff --
You try to log the current thread name in `receive` and then, you can see
multiple threads access `receive`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/3984#discussion_r22756617
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ActorReceiver.scala
---
@@ -149,43 +181,61 @@ private[streaming] class ActorReceiver[T: ClassTag](
class Supervisor extends Actor {
override val supervisorStrategy = receiverSupervisorStrategy
-val worker = context.actorOf(props, name)
-logInfo(Started receiver worker at: + worker.path)
-
-val n: AtomicInteger = new AtomicInteger(0)
-val hiccups: AtomicInteger = new AtomicInteger(0)
-
--- End diff --
I see, Akka's actor makes sure the visibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/3984#discussion_r22756597
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ActorReceiver.scala
---
@@ -149,43 +181,61 @@ private[streaming] class ActorReceiver[T: ClassTag](
class Supervisor extends Actor {
override val supervisorStrategy = receiverSupervisorStrategy
-val worker = context.actorOf(props, name)
-logInfo(Started receiver worker at: + worker.path)
-
-val n: AtomicInteger = new AtomicInteger(0)
-val hiccups: AtomicInteger = new AtomicInteger(0)
-
--- End diff --
Hi, @sarutak , I went back to Akka's document
http://doc.akka.io/docs/akka/snapshot/general/jmm.html (Actors and the Java
Memory Model), I think they stated that,
internal fields of the actor are visible when the next message is
processed by that actor. So fields in your actor need not be volatile or
equivalent.
So, we don't need to explicitly mark these variables to be volatile?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/3984#discussion_r22756565
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ActorReceiver.scala
---
@@ -149,43 +181,61 @@ private[streaming] class ActorReceiver[T: ClassTag](
class Supervisor extends Actor {
override val supervisorStrategy = receiverSupervisorStrategy
-val worker = context.actorOf(props, name)
-logInfo(Started receiver worker at: + worker.path)
-
-val n: AtomicInteger = new AtomicInteger(0)
-val hiccups: AtomicInteger = new AtomicInteger(0)
-
--- End diff --
I see what you meanyes, you're correct, since the running thread of the
actor can be changed before the updated value is written back to the memory
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-69408847 [Test build #25342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25342/consoleFull) for PR 3984 at commit [`d5a57db`](https://github.com/apache/spark/commit/d5a57db38248f637beb9475cc1637a1aab7eba25). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-69408857 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25342/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
GitHub user CodingCat opened a pull request: https://github.com/apache/spark/pull/3984 [SPARK-5174][SPARK-5175] provide more APIs in ActorHelper https://issues.apache.org/jira/browse/SPARK-5174 https://issues.apache.org/jira/browse/SPARK-5175 1. add more APIs and scala docs in ActorHelper 2. fix several bugs in the existing message handler in actor receiver supervisor You can merge this pull request into a Git repository by running: $ git pull https://github.com/CodingCat/spark SPARK-5174 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/3984.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3984 commit d5a57db38248f637beb9475cc1637a1aab7eba25 Author: CodingCat zhunans...@gmail.com Date: 2015-01-09T21:00:24Z provide more APIs in ActorHelper --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-69398734 Hi, @tdas, do you mind reviewing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5174][SPARK-5175] provide more APIs in ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3984#issuecomment-69399043 [Test build #25342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25342/consoleFull) for PR 3984 at commit [`d5a57db`](https://github.com/apache/spark/commit/d5a57db38248f637beb9475cc1637a1aab7eba25). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
