[GitHub] spark pull request: [SPARK-5912] [docs] [mllib] Small fixes to Chi...
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/4732 [SPARK-5912] [docs] [mllib] Small fixes to ChiSqSelector docs Fixes: * typo in Scala example * Removed comment usually applied on sparse data since that is debatable * small edits to text for clarity CC: @avulanov I noticed a typo post-hoc and ended up making a few small edits. Do the changes look OK? You can merge this pull request into a Git repository by running: $ git pull https://github.com/jkbradley/spark chisqselector-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/4732.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4732 commit 3f3f9f4968ff1a8f45be6dbaead54eb1ea6df406 Author: Joseph K. Bradley jos...@databricks.com Date: 2015-02-23T21:18:06Z small fixes to ChiSqSelector docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5912] [docs] [mllib] Small fixes to Chi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4732#issuecomment-75637616 [Test build #27862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27862/consoleFull) for PR 4732 at commit [`3f3f9f4`](https://github.com/apache/spark/commit/3f3f9f4968ff1a8f45be6dbaead54eb1ea6df406). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5912] [docs] [mllib] Small fixes to Chi...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4732#issuecomment-75653327 I just added a Java example, copied from your Scala example modified for Java. I've run it, and it works. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5912] [docs] [mllib] Small fixes to Chi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4732#issuecomment-75653935 [Test build #27865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27865/consoleFull) for PR 4732 at commit [`9656a3b`](https://github.com/apache/spark/commit/9656a3b52e00acf654df37dfc5023d344ba09cd9). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5912] [docs] [mllib] Small fixes to Chi...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4732#issuecomment-75654741 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27862/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5912] [docs] [mllib] Small fixes to Chi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4732#issuecomment-75654727 [Test build #27862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27862/consoleFull) for PR 4732 at commit [`3f3f9f4`](https://github.com/apache/spark/commit/3f3f9f4968ff1a8f45be6dbaead54eb1ea6df406). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * ` case class Params(` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5912] [docs] [mllib] Small fixes to Chi...
Github user avulanov commented on the pull request: https://github.com/apache/spark/pull/4732#issuecomment-75645316 @jkbradley Thank you! I am OK with these fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5912] [docs] [mllib] Small fixes to Chi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4732#issuecomment-75668365 [Test build #27865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27865/consoleFull) for PR 4732 at commit [`9656a3b`](https://github.com/apache/spark/commit/9656a3b52e00acf654df37dfc5023d344ba09cd9). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5912] [docs] [mllib] Small fixes to Chi...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4732#issuecomment-75668373 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27865/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5912] [docs] [mllib] Small fixes to Chi...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4732#issuecomment-75669836 LGTM. Merged into master and branch-1.3. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5912] [docs] [mllib] Small fixes to Chi...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4732 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
