[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/4731#discussion_r25377328 --- Diff: python/docs/conf.py --- @@ -48,16 +48,16 @@ # General information about the project. project = u'PySpark' -copyright = u'2014, Author' +copyright = u'' --- End diff -- Should this be Apache Software Foundation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/4731#discussion_r25377450 --- Diff: dev/create-release/create-release.sh --- @@ -237,7 +237,7 @@ if [[ ! $@ =~ --skip-package ]]; then sbt/sbt clean cd docs # Compile docs with Java 7 to use nicer format - JAVA_HOME=$JAVA_7_HOME PRODUCTION=1 jekyll build + JAVA_HOME=$JAVA_7_HOME PRODUCTION=1 RELEASE_VERSION=$RELEASE_VERSION jekyll build --- End diff -- Since we're updating this line anyway, can we change it to: ``` JAVA_HOME=$JAVA_7_HOME PRODUCTION=1 RELEASE_VERSION=$RELEASE_VERSION jekyll build ``` This will protect against word splitting, though unlikely here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4731#discussion_r25377611 --- Diff: python/docs/conf.py --- @@ -48,16 +48,16 @@ # General information about the project. project = u'PySpark' -copyright = u'2014, Author' +copyright = u'' --- End diff -- If the question is who owns the copyright in the project, no it's not the ASF. Everyone is effectively licensing their contributions to the ASF under the terms of the CLA but don't actually assign copyright. Anyway. For purposes of this line, blank is OK IMHO. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/4731#discussion_r25379563 --- Diff: python/docs/conf.py --- @@ -48,16 +48,16 @@ # General information about the project. project = u'PySpark' -copyright = u'2014, Author' +copyright = u'' --- End diff -- I did not figure out the right answer here, so leave it as blank. We did not have this kind of information in the Java/Scala API docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4731#issuecomment-76061584 [Test build #27959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27959/consoleFull) for PR 4731 at commit [`c9744c9`](https://github.com/apache/spark/commit/c9744c9435ba419eced67719f7273a0cccb7fc3b). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/4731#issuecomment-76068202 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4731 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4731#issuecomment-76076743 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27959/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4731#issuecomment-76082437 Thanks! Merged to master and 1.3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4731#issuecomment-76076725 [Test build #27959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27959/consoleFull) for PR 4731 at commit [`c9744c9`](https://github.com/apache/spark/commit/c9744c9435ba419eced67719f7273a0cccb7fc3b). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4731#issuecomment-75629173 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27861/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4731#issuecomment-75629156 [Test build #27861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27861/consoleFull) for PR 4731 at commit [`08cbc3f`](https://github.com/apache/spark/commit/08cbc3f2f6ea21ecfb491e89b521679d4fb24879). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5944] [PySpark] fix version in Python A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4731#issuecomment-75615211 [Test build #27861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27861/consoleFull) for PR 4731 at commit [`08cbc3f`](https://github.com/apache/spark/commit/08cbc3f2f6ea21ecfb491e89b521679d4fb24879). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
