[GitHub] spark pull request: [SPARK-5951][YARN] Remove unreachable driver m...

2015-02-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/4730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5951][YARN] Remove unreachable driver m...

2015-02-26 Thread andrewor14
Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/4730#issuecomment-76288295
  
I just realized that this patch doesn't actually remove support for those 
deprecated configs; they were already removed in a patch #3607 that was merged 
beforehand. What this patch does is just to stop showing the deprecation 
messages for these configs.

LGTM I'm merging this into master and 1.3.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5951][YARN] Remove unreachable driver m...

2015-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4730#issuecomment-75830518
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27894/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5951][YARN] Remove unreachable driver m...

2015-02-24 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4730#issuecomment-75830504
  
  [Test build #27894 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27894/consoleFull)
 for   PR 4730 at commit 
[`977dc96`](https://github.com/apache/spark/commit/977dc967eb3f2e718df68729d614efc48a47c9da).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5951][YARN] Remove unreachable driver m...

2015-02-24 Thread srowen
Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/4730#issuecomment-75733025
  
Does @andrewor14 's comment at 
https://github.com/apache/spark/pull/3590#discussion_r25214428 affect this PR? 
should more stuff be removed for 1.4?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5951][YARN] Remove unreachable driver m...

2015-02-24 Thread zuxqoj
Github user zuxqoj commented on the pull request:

https://github.com/apache/spark/pull/4730#issuecomment-75737485
  
@srowen 
Does @andrewor14 's comment at #3590 (comment) affect this PR?
no, he is talking about removing  deprecated properties 
(SPARK_MASTER_MEMORY and spark.master.memory) from spark in 1.4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5951][YARN] Remove unreachable driver m...

2015-02-24 Thread andrewor14
Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/4730#issuecomment-75816220
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5951][YARN] Remove unreachable driver m...

2015-02-24 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4730#issuecomment-75816379
  
  [Test build #27894 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27894/consoleFull)
 for   PR 4730 at commit 
[`977dc96`](https://github.com/apache/spark/commit/977dc967eb3f2e718df68729d614efc48a47c9da).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5951][YARN] Remove unreachable driver m...

2015-02-24 Thread andrewor14
Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/4730#issuecomment-75816423
  
@zuxqoj Thanks for this PR. Actually I'd suggest that we just remove all 
the deprecated properties here. Calling a Spark executor a Worker is just as 
misleading as calling a Spark driver a Master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5951][YARN] Remove unreachable driver m...

2015-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4730#issuecomment-75594177
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5951][YARN] Remove unreachable driver m...

2015-02-23 Thread sryza
Github user sryza commented on the pull request:

https://github.com/apache/spark/pull/4730#issuecomment-75655834
  
LGTM.  This seems in line with SPARK-1953's eradication of these properties 
for yarn-client mode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org