[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110628154 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110661369 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110672434 [Test build #34582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34582/console) for PR 6716 at commit [`e2e8dbd`](https://github.com/apache/spark/commit/e2e8dbdf93e83a0ce33dd8e0b0e3bc223fdc3ec9). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `abstract class LeafMathExpression(c: Double, name: String)` * `case class EulerNumber() extends LeafMathExpression(math.E, E)` * `case class Pi() extends LeafMathExpression(math.Pi, PI)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110639589 (want to test with this HiveContext also switching to using udfs here) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110639487 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110672450 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110635224 [Test build #34562 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34562/console) for PR 6716 at commit [`db331c9`](https://github.com/apache/spark/commit/db331c964a9b9950447c20b89c6bbce40f2c7a2b). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `abstract class LeafMathExpression(c: Double, name: String)` * `case class E() extends LeafMathExpression(math.E, E)` * `case class Pi() extends LeafMathExpression(math.Pi, PI)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110635265 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110640184 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110640149 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110649509 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110626124 [Test build #34576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34576/consoleFull) for PR 6716 at commit [`e2e8dbd`](https://github.com/apache/spark/commit/e2e8dbdf93e83a0ce33dd8e0b0e3bc223fdc3ec9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110640758 [Test build #34582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34582/consoleFull) for PR 6716 at commit [`e2e8dbd`](https://github.com/apache/spark/commit/e2e8dbdf93e83a0ce33dd8e0b0e3bc223fdc3ec9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110661359 [Test build #34576 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34576/console) for PR 6716 at commit [`e2e8dbd`](https://github.com/apache/spark/commit/e2e8dbdf93e83a0ce33dd8e0b0e3bc223fdc3ec9). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `abstract class LeafMathExpression(c: Double, name: String)` * `case class EulerNumber() extends LeafMathExpression(math.E, E)` * `case class Pi() extends LeafMathExpression(math.Pi, PI)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110625900 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110625923 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110649491 [Test build #34567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34567/console) for PR 6716 at commit [`11b351c`](https://github.com/apache/spark/commit/11b351c2a0fc9910a03d15befa09b41918b83396). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `abstract class LeafMathExpression(c: Double, name: String)` * `case class EulerNumber() extends LeafMathExpression(math.E, E)` * `case class Pi() extends LeafMathExpression(math.Pi, PI)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110615775 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110615798 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110616118 [Test build #34567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34567/consoleFull) for PR 6716 at commit [`11b351c`](https://github.com/apache/spark/commit/11b351c2a0fc9910a03d15befa09b41918b83396). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6716#discussion_r32092034
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -145,6 +145,17 @@ class SQLQuerySuite extends QueryTest with
BeforeAndAfterAll with SQLTestUtils {
Seq(Row(1), Row(2)))
}
+ test(constant functions) {
--- End diff --
let's be consistent with @chenghao-intel's length pr, and move this test
into DataFrameFunctionSuite.scala.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6716#discussion_r32092540
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -145,6 +145,17 @@ class SQLQuerySuite extends QueryTest with
BeforeAndAfterAll with SQLTestUtils {
Seq(Row(1), Row(2)))
}
+ test(constant functions) {
--- End diff --
OK. Anyway, I think it looks weird to test `sql()` in
DataFrameFunctionsSuite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6716 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110828845 Thanks. I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110301112 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110301122 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110301712 [Test build #34498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34498/consoleFull) for PR 6716 at commit [`00f6b59`](https://github.com/apache/spark/commit/00f6b59909ec1311ff33d0d3daac643dcab699f3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110283074 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
GitHub user adrian-wang opened a pull request: https://github.com/apache/spark/pull/6716 [SPARK-8215] [SPARK-8212] [SQL] add leaf math expression for e and pi You can merge this pull request into a Git repository by running: $ git pull https://github.com/adrian-wang/spark epi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/6716.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6716 commit 6fa757ef21ccdd266d5928f8911ccca2f50709a7 Author: Daoyuan Wang daoyuan.w...@intel.com Date: 2015-06-09T09:00:16Z add PI and E --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110283435 [Test build #34493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34493/consoleFull) for PR 6716 at commit [`6fa757e`](https://github.com/apache/spark/commit/6fa757ef21ccdd266d5928f8911ccca2f50709a7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110283086 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110317251 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110318353 [Test build #34501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34501/consoleFull) for PR 6716 at commit [`e6783ef`](https://github.com/apache/spark/commit/e6783ef281922dff8c016a5b032e78892a58e45d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110317241 [Test build #34493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34493/console) for PR 6716 at commit [`6fa757e`](https://github.com/apache/spark/commit/6fa757ef21ccdd266d5928f8911ccca2f50709a7). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `abstract class LeafMathExpression(c: Double, name: String)` * `case class E() extends LeafMathExpression(math.E, E)` * `case class Pi() extends LeafMathExpression(math.Pi, PI)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110317966 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110317985 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110437175 Can you also add the Python version? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6716#discussion_r32037880
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -945,6 +945,14 @@ object functions {
def cosh(columnName: String): Column = cosh(Column(columnName))
/**
+ * Returns the value of the e.
--- End diff --
Why not just use the java.math definition, i.e.
```The double value that is closer than any other to e, the base of the
natural logarithms.```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6716#discussion_r32037994
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -21,8 +21,37 @@ import
org.apache.spark.sql.catalyst.expressions.codegen._
import org.apache.spark.sql.types.{DataType, DoubleType}
/**
+ * A leaf expression specifically for math constants. Math constants
expect no input.
+ * @param c The math constant.
+ * @param name The short name of the function
+ */
+abstract class LeafMathExpression(c: Double, name: String)
+ extends LeafExpression with Serializable {
+ self: Product =
+
+ override def dataType: DataType = DoubleType
+ override def foldable: Boolean = true
+ override def nullable: Boolean = false
+ override def toString: String = s$name()
+
+ override def eval(input: Row): Any = c
+
+ // name of constant in java.lang.Math
+ def constName: String = name
--- End diff --
since we don't use this right now, let's remove this extra method and just
use name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6716#discussion_r32037920
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1106,6 +1114,14 @@ object functions {
def log1p(columnName: String): Column = log1p(Column(columnName))
/**
+ * Returns the value of the pi.
--- End diff --
```The double value that is closer than any other to pi, the ratio of the
circumference of a circle to its diameter.```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6716#discussion_r32074637
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
---
@@ -23,6 +23,24 @@ import org.apache.spark.sql.types.DoubleType
class MathFunctionsSuite extends SparkFunSuite with ExpressionEvalHelper {
/**
+ * Used for testing leaf math expressions.
+ *
+ * @param e expression
+ * @param c The constants in scala.math
+ * @param domain The set of values to run the function with
+ * @tparam T Generic type for primitives
+ */
+ private def testLeaf[T](
+ e: () = Expression,
+ c: T,
+ domain: Iterable[T] = (-20 to 20).map(_ * 0.1)): Unit = {
--- End diff --
since this is unused, why not just remove it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6716#discussion_r32074563
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -21,8 +21,37 @@ import
org.apache.spark.sql.catalyst.expressions.codegen._
import org.apache.spark.sql.types.{DataType, DoubleType}
/**
+ * A leaf expression specifically for math constants. Math constants
expect no input.
+ * @param c The math constant.
+ * @param name The short name of the function
+ */
+abstract class LeafMathExpression(c: Double, name: String)
+ extends LeafExpression with Serializable {
+ self: Product =
+
+ override def dataType: DataType = DoubleType
+ override def foldable: Boolean = true
+ override def nullable: Boolean = false
+ override def toString: String = s$name()
+
+ override def eval(input: Row): Any = c
+
+ // name of constant in java.lang.Math
+ def constName: String = name
+
+ override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
String = {
+s
+ boolean ${ev.isNull} = false;
+ ${ctx.javaType(dataType)} ${ev.primitive} =
${ctx.defaultValue(dataType)};
--- End diff --
why not just ...
```
${ctx.javaType(dataType)} ${ev.primitive} = ${ev.primitive} =
java.lang.Math.$constName;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110345427 [Test build #34501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34501/console) for PR 6716 at commit [`e6783ef`](https://github.com/apache/spark/commit/e6783ef281922dff8c016a5b032e78892a58e45d). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `abstract class LeafMathExpression(c: Double, name: String)` * `case class E() extends LeafMathExpression(math.E, E)` * `case class Pi() extends LeafMathExpression(math.Pi, PI)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110345442 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110352181 **[Test build #34498 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34498/console)** for PR 6716 at commit [`00f6b59`](https://github.com/apache/spark/commit/00f6b59909ec1311ff33d0d3daac643dcab699f3) after a configured wait of `175m`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110592215 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110592227 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110592407 [Test build #34562 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34562/consoleFull) for PR 6716 at commit [`db331c9`](https://github.com/apache/spark/commit/db331c964a9b9950447c20b89c6bbce40f2c7a2b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32088989 --- Diff: python/pyspark/sql/functions.py --- @@ -348,6 +358,24 @@ def randn(seed=None): return Column(jc) +@since(1.5) +def e(): +Returns the double value that is closer than any other to e, the base of the natural +logarithms. + +import math +return Column(math.e) --- End diff -- and add a docstring test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32088982 --- Diff: python/pyspark/sql/functions.py --- @@ -348,6 +358,24 @@ def randn(seed=None): return Column(jc) +@since(1.5) +def e(): +Returns the double value that is closer than any other to e, the base of the natural +logarithms. + +import math +return Column(math.e) + + +@since(1.5) +def pi(): +Returns the double value that is closer than any other to pi, the ratio of the circumference +of a circle to its diameter. + +import math +return Column(math.pi) --- End diff -- call the jvm function here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32088958 --- Diff: python/pyspark/sql/functions.py --- @@ -188,11 +195,14 @@ def _(): globals()[_name] = since(1.4)(_create_binary_mathfunction(_name, _doc)) for _name, _doc in _window_functions.items(): globals()[_name] = since(1.4)(_create_window_function(_name, _doc)) +for _name, _doc in _functions_1_5.items(): --- End diff -- i don't think u need this, since you explicitly defined it. you might need to add it to __all__ at the top of the file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32088977 --- Diff: python/pyspark/sql/functions.py --- @@ -348,6 +358,24 @@ def randn(seed=None): return Column(jc) +@since(1.5) +def e(): +Returns the double value that is closer than any other to e, the base of the natural +logarithms. + +import math +return Column(math.e) --- End diff -- can we call the jvm function here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6716#discussion_r32089027
--- Diff: python/pyspark/sql/functions.py ---
@@ -138,6 +138,13 @@ def _():
'bitwiseNOT': 'Computes bitwise not.',
}
+_functions_1_5 = {
--- End diff --
u don't need this here either.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6716#discussion_r32089009 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -100,6 +125,16 @@ abstract class BinaryMathExpression(f: (Double, Double) = Double, name: String) +// Leaf math functions + + + +case class E() extends LeafMathExpression(math.E, E) --- End diff -- i was thinking - E is too hard to grep for. Let's name this EulerNumber --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110352195 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110588870 [Test build #34560 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34560/consoleFull) for PR 6716 at commit [`599ddd8`](https://github.com/apache/spark/commit/599ddd8aad3971f598552c9359580d1920593bdb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110588564 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110588606 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110589471 [Test build #34560 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34560/console) for PR 6716 at commit [`599ddd8`](https://github.com/apache/spark/commit/599ddd8aad3971f598552c9359580d1920593bdb). * This patch **fails Python style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `abstract class LeafMathExpression(c: Double, name: String)` * `case class E() extends LeafMathExpression(math.E, E)` * `case class Pi() extends LeafMathExpression(math.Pi, PI)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8215] [SPARK-8212] [SQL] add leaf math ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6716#issuecomment-110589481 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
