[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-125661251 Merged into master. @vinodkc Next time, please ping other people on the JIRA page before you start coding to avoid duplicate work. Could you send a message the JIRA page? So I know your JIRA account and I can assign this ticket to you. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-125820807 @mengxr , I've added message in JIRA page from my JIRA account. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-122298404 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-122298461 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-122299022 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-122327833 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-122336911 [Test build #37643 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37643/console) for PR 7325 at commit [`93156f2`](https://github.com/apache/spark/commit/93156f2c53123a498005de48a9850703a1a2a3ef). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-122336994 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-122328445 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-122328429 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-122329173 [Test build #37643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37643/consoleFull) for PR 7325 at commit [`93156f2`](https://github.com/apache/spark/commit/93156f2c53123a498005de48a9850703a1a2a3ef). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/7325#discussion_r34823431
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -269,6 +271,7 @@ object ALS {
* @param lambda regularization factor (recommended: 0.01)
* @param blocks level of parallelism to split computation into
* @param seed random seed
+ * @since 0.8.0
--- End diff --
This overload of `train` looks like it was since 0.9.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-122050422 I double-checked the tags and LGTM except for the one overloaded `train` I commented on - probably because its declaration is multi-line, so a grep won't catch it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-121070540 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120075058 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/7325 [SPARK-8919][Documentation, MLlib]Added @since tags to mllib.recommendation You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark add_since_mllib.recommendation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/7325.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7325 commit c41335072cf370a971e0f79eeb85ebfaa8e85ca7 Author: vinodkc vinod.kc...@gmail.com Date: 2015-07-09T17:08:28Z Added @since --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120080866 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120080892 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120090509 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120080332 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120081632 [Test build #36949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36949/consoleFull) for PR 7325 at commit [`c413350`](https://github.com/apache/spark/commit/c41335072cf370a971e0f79eeb85ebfaa8e85ca7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120087616 @coderxiang Could you help review this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120090249 [Test build #36949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36949/console) for PR 7325 at commit [`c413350`](https://github.com/apache/spark/commit/c41335072cf370a971e0f79eeb85ebfaa8e85ca7). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120140887 Just realized one issue with adding the `@since` tag. For overloaded methods, it inherits the doc from its parent if no JavaDoc is provided. However, if we want to add `@since`, we have to add JavaDoc. Then we need to copy the JavaDoc from parent, which makes it hard to keep docs in sync. @rxin Is it better to implement `@since` as an annotation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120166407 How would the annotation work for each method in javadoc? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120168076 Annotation supports methods as well. I don't think it affects binary compatibility. ~~~scala @since(1.3.0) def func(...) ~~~ We can make them show up in the generated doc like `@Experimental`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8919][Documentation, MLlib]Added @since...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7325#issuecomment-120172965 Yea if we can figure out a way for show to show up, I think that's good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
