[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user stumped2 commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-121036669 Closing as per https://issues.apache.org/jira/browse/INFRA-9988 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user stumped2 closed the pull request at: https://github.com/apache/spark/pull/7367 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-121024668 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-121015035 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-121014914 [Test build #37139 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37139/console) for PR 7367 at commit [`4fa3c8f`](https://github.com/apache/spark/commit/4fa3c8f880f761d4d4113ac747d6c2688c8dfd3b). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-121002318 [Test build #37139 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37139/consoleFull) for PR 7367 at commit [`4fa3c8f`](https://github.com/apache/spark/commit/4fa3c8f880f761d4d4113ac747d6c2688c8dfd3b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-121001097 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-121001068 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-120978939 LGTM pending Jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-120978883 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-120978762 This was needed because they show up in the generated Java API doc. However, since we don't show package private classes/methods anymore, they should be removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-120870680 Why is this needed though? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7367#issuecomment-120845435 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8991][ML]Update SharedParamsCodeGen's G...
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/7367 [SPARK-8991][ML]Update SharedParamsCodeGen's Generated Documentation Removed private[ml] from Generated documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark fix_sharedparmascodegen Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/7367.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7367 commit 7e19025450c55ccbcef45dd8d460bc8dfdeef1c2 Author: Vinod K C Date: 2015-07-13T10:27:33Z Removed private[ml] commit 4fa3c8f880f761d4d4113ac747d6c2688c8dfd3b Author: Vinod K C Date: 2015-07-13T10:45:59Z Adding auto generated code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
