[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user yanboliang closed the pull request at: https://github.com/apache/spark/pull/7357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-163701403 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47502/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-163701306 **[Test build #47502 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47502/console)** for PR 7357 at commit [`1685043`](https://github.com/apache/spark/commit/1685043c0f201b9e3463bac460630d0738ca6953) after a configured wait of `175m`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-163701402 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-163649655 [Test build #47502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47502/consoleFull) for PR 7357 at commit [`1685043`](https://github.com/apache/spark/commit/1685043c0f201b9e3463bac460630d0738ca6953). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-135331297 Yeah, I think the question is, what's the need / motivation? I don't see this being used in the code. If it's just because it sounds useful, I'm not sure that's enough justification. If it can simplify or speed up project code, that's an argument worth advancing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-134918812 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-134918751 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-134934506 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-134934396 [Test build #41616 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41616/console) for PR 7357 at commit [`1685043`](https://github.com/apache/spark/commit/1685043c0f201b9e3463bac460630d0738ca6953). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-134919728 [Test build #41616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41616/consoleFull) for PR 7357 at commit [`1685043`](https://github.com/apache/spark/commit/1685043c0f201b9e3463bac460630d0738ca6953). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-134934508 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41616/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/7357#issuecomment-135300832 @yanboliang I think there are some [discussions about whether we should enrich the Vectors API](https://www.mail-archive.com/user@spark.apache.org/msg35434.html) CC @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...
Github user Mageswaran1989 commented on a diff in the pull request: https://github.com/apache/spark/pull/7357#discussion_r38063538 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -692,6 +744,29 @@ class SparseVector @Since(1.0.0) ( private[spark] override def toBreeze: BV[Double] = new BSV[Double](indices, values, size) + private[spark] override def mapActiveValues(f: Double = Double): Vector = +new SparseVector(size, indices.clone(), values.map(f)) + + private[spark] def mapActivePairs(f: (Int, Double) = Double): Vector = { --- End diff -- I am learning Scala. Could you please explain how this maps only the active pairs? what is happening in the line no: 756 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org