[GitHub] spark pull request: [Spark-4509] Revert EC2 tag-based cluster memb...
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/3453 [Spark-4509] Revert EC2 tag-based cluster membership patch This PR reverts changes related to tag-based cluster membership. As discussed in SPARK-3332, we didn't figure out a safe strategy to use tags to determine cluster membership, because tagging is not atomic. The following changes are reverted: SPARK-2333: 94053a7b766788bb62e2dbbf352ccbcc75f71fc0 SPARK-3213: 7faf755ae4f0cf510048e432340260a6e609066d SPARK-3608: 78d4220fa0bf2f9ee663e34bbf3544a5313b02f0. I tested launch, login, and destroy. It is easy to check the diff by comparing it to Josh's patch for branch-1.1: https://github.com/apache/spark/pull/2225/files @JoshRosen I sent the PR to master. It might be easier for us to keep master and branch-1.2 the same at this time. We can always re-apply the patch once we figure out a stable solution. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mengxr/spark SPARK-4509 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/3453.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3453 commit 35963a1ba2a94e18adf07d6879aeb53379cd8f14 Author: Xiangrui Meng m...@databricks.com Date: 2014-11-25T09:11:28Z Revert SPARK-3608 Break if the instance tag naming succeeds This reverts commit 78d4220fa0bf2f9ee663e34bbf3544a5313b02f0. commit 4298ea52d4ffddd3a209684a991918f3114f44d4 Author: Xiangrui Meng m...@databricks.com Date: 2014-11-25T09:16:59Z revert 7faf755ae4f0cf510048e432340260a6e609066d commit f0b708bb125ebde0f65a1d6130a5168793ca8a66 Author: Xiangrui Meng m...@databricks.com Date: 2014-11-25T09:21:38Z revert 94053a7b766788bb62e2dbbf352ccbcc75f71fc0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-4509] Revert EC2 tag-based cluster memb...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3453#issuecomment-64347503 [Test build #23836 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23836/consoleFull) for PR 3453 at commit [`f0b708b`](https://github.com/apache/spark/commit/f0b708bb125ebde0f65a1d6130a5168793ca8a66). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-4509] Revert EC2 tag-based cluster memb...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3453#issuecomment-64386611 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23836/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-4509] Revert EC2 tag-based cluster memb...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3453#issuecomment-64386599 [Test build #23836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23836/consoleFull) for PR 3453 at commit [`f0b708b`](https://github.com/apache/spark/commit/f0b708bb125ebde0f65a1d6130a5168793ca8a66). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-4509] Revert EC2 tag-based cluster memb...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3453#issuecomment-64494391 Ok, I compared the diff here with that in #2225 and verified that the content is the same. This LGTM I'm merging this into master and 1.2 thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-4509] Revert EC2 tag-based cluster memb...
Github user mengxr closed the pull request at: https://github.com/apache/spark/pull/3453 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
