[GitHub] spark pull request: [SPARK-3907][sql] add truncate table support
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-61664006 @wangxiaojing @tianyi @marmbrus Hi, wangxiaojing, I have an issues for this PR. Currently the ```truncate table``` works fine in the situation that current table is in the corresponding database session. But it doesn't work in the scenario which the table is not in the corresponding database session. What I mean is : Assume we have two database:``` default```, ``` dw```. A table named ```test_table``` in database ```dw``` By default we login as default database session. So I runï¼ ``` use dw; truncate table test_table [partions..]; is OK. ``` If I just use the default database ```default``` to run: ``` use default; truncate table dw.test_table; ``` It will throw exception ``` Failed to parse: truncate table dw.test_table. line 1:17 missing EOF at '.' near 'dw' ``` It's a bug when parsing the ```truncate table xxx``` It would be nicer to fix it : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3907][sql] add truncate table support
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-61700627 @OopsOutOfMemory please file a JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3907][sql] add truncate table support
Github user wangxiaojing commented on the pull request:
https://github.com/apache/spark/pull/2770#issuecomment-61747497
@OopsOutOfMemory Thanks a lot!
This bug is also found in the hive.
eg: {code}TRUNCATE TABLE default.test;
FAILED: ParseException line 1:22 missing EOF at '.' near 'default'{code}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3907][sql] add truncate table support
Github user OopsOutOfMemory commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-61748080 Yep, that is what I guess yesterday. I think we should support all the commands which are similar to this. The JIRA for this one locate in below: https://issues.apache.org/jira/browse/SPARK-4232 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60706609 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60706659 Can you please make the title SPARK- so that the merge script recognizes the JIRA? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60707031 [Test build #22331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22331/consoleFull) for PR 2770 at commit [`63dbd81`](https://github.com/apache/spark/commit/63dbd81986c5b8f38721185f33e7550294d1ab5b). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60709839 [Test build #22331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22331/consoleFull) for PR 2770 at commit [`63dbd81`](https://github.com/apache/spark/commit/63dbd81986c5b8f38721185f33e7550294d1ab5b). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60709842 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22331/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3907][sql] add truncate table support
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60710381 Thanks! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3907][sql] add truncate table support
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2770 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60535425 [Test build #468 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/468/consoleFull) for PR 2770 at commit [`7a03707`](https://github.com/apache/spark/commit/7a0370776dc0d60e6923c2c18d69c1a1ee94eed4). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60535476 [Test build #468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/468/consoleFull) for PR 2770 at commit [`7a03707`](https://github.com/apache/spark/commit/7a0370776dc0d60e6923c2c18d69c1a1ee94eed4). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60536538 [Test build #470 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/470/consoleFull) for PR 2770 at commit [`7a03707`](https://github.com/apache/spark/commit/7a0370776dc0d60e6923c2c18d69c1a1ee94eed4). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60536592 [Test build #470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/470/consoleFull) for PR 2770 at commit [`7a03707`](https://github.com/apache/spark/commit/7a0370776dc0d60e6923c2c18d69c1a1ee94eed4). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60537463 It appears there are some style violations: ``` [marmbrus@michaels-mbp spark (pr/2770)]$ sbt hive/scalastyle [info] Set current project to spark-parent (in build file:/Users/marmbrus/workspace/spark/) error file=/Users/marmbrus/workspace/spark/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala message=File line length exceeds 100 characters line=477 error file=/Users/marmbrus/workspace/spark/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala message=insert.a.single.space.after.comment.start.and.before.end.message line=125 column=4 error file=/Users/marmbrus/workspace/spark/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala message=insert.a.single.space.after.comment.start.and.before.end.message line=477 column=4 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60475396 [Test build #442 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/442/consoleFull) for PR 2770 at commit [`f6e710e`](https://github.com/apache/spark/commit/f6e710e7d2c455d57065bd712789b7dd0bf357fb). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60475486 [Test build #442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/442/consoleFull) for PR 2770 at commit [`f6e710e`](https://github.com/apache/spark/commit/f6e710e7d2c455d57065bd712789b7dd0bf357fb). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2770#discussion_r19324134
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -121,7 +121,8 @@ private[hive] object HiveQl {
// Commands that we do not need to explain.
protected val noExplainCommands = Seq(
TOK_CREATETABLE,
-TOK_DESCTABLE
+TOK_DESCTABLE,
+TOK_TRUNCATETABLE
--- End diff --
Can you add a comment below explaining this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60332619 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60332934 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22102/consoleFull) for PR 2770 at commit [`f6e710e`](https://github.com/apache/spark/commit/f6e710e7d2c455d57065bd712789b7dd0bf357fb). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60335112 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22102/consoleFull) for PR 2770 at commit [`f6e710e`](https://github.com/apache/spark/commit/f6e710e7d2c455d57065bd712789b7dd0bf357fb). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60335115 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22102/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60335863 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60336321 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22104/consoleFull) for PR 2770 at commit [`f6e710e`](https://github.com/apache/spark/commit/f6e710e7d2c455d57065bd712789b7dd0bf357fb). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60339379 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22104/consoleFull) for PR 2770 at commit [`f6e710e`](https://github.com/apache/spark/commit/f6e710e7d2c455d57065bd712789b7dd0bf357fb). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-60339381 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22104/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-59672228 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/402/consoleFull) for PR 2770 at commit [`f6e710e`](https://github.com/apache/spark/commit/f6e710e7d2c455d57065bd712789b7dd0bf357fb). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-59673393 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/402/consoleFull) for PR 2770 at commit [`f6e710e`](https://github.com/apache/spark/commit/f6e710e7d2c455d57065bd712789b7dd0bf357fb). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user tianyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/2770#discussion_r19004814
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -121,7 +121,8 @@ private[hive] object HiveQl {
// Commands that we do not need to explain.
protected val noExplainCommands = Seq(
TOK_CREATETABLE,
-TOK_DESCTABLE
+TOK_DESCTABLE,
+TOK_TRUNCATETABLE
--- End diff --
@adrian-wang I think `explain` for `truncate table` is meaningless.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2770#discussion_r19006488
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -121,7 +121,8 @@ private[hive] object HiveQl {
// Commands that we do not need to explain.
protected val noExplainCommands = Seq(
TOK_CREATETABLE,
-TOK_DESCTABLE
+TOK_DESCTABLE,
+TOK_TRUNCATETABLE
--- End diff --
I think we should add that in `nativeCommands`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user wangxiaojing commented on a diff in the pull request:
https://github.com/apache/spark/pull/2770#discussion_r19007078
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -121,7 +121,8 @@ private[hive] object HiveQl {
// Commands that we do not need to explain.
protected val noExplainCommands = Seq(
TOK_CREATETABLE,
-TOK_DESCTABLE
+TOK_DESCTABLE,
+TOK_TRUNCATETABLE
--- End diff --
If add codetruncate table/code in codenativeCommands/code,the sql
codetruncate table test columns(i)/code will run hive mapreduce.At present,
the columns way only support rcfile in hive
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-59369912 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/387/consoleFull) for PR 2770 at commit [`e483547`](https://github.com/apache/spark/commit/e48354730645951e2fe2c485cab310df8033bf72). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-59375645 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/387/consoleFull) for PR 2770 at commit [`e483547`](https://github.com/apache/spark/commit/e48354730645951e2fe2c485cab310df8033bf72). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user wangxiaojing commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-59466262 @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2770#discussion_r19001778
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -121,7 +121,8 @@ private[hive] object HiveQl {
// Commands that we do not need to explain.
protected val noExplainCommands = Seq(
TOK_CREATETABLE,
-TOK_DESCTABLE
+TOK_DESCTABLE,
+TOK_TRUNCATETABLE
--- End diff --
why is truncate table a no-explain-command?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2770#discussion_r18809978
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -224,6 +225,11 @@ private[hive] object HiveQl {
try {
val tree = getAst(sql)
if (nativeCommands contains tree.getText) {
+if(tree.asInstanceOf[ASTNode].getText == TOK_TRUNCATETABLE){
+ if(tree.getChildren.exists(_.asInstanceOf[ASTNode].getText ==
TOK_TABCOLNAME) ){
+sys.error(Truncate tabel can not support columns)
--- End diff --
âtabelâ is a typo. I think it's better not to include this part here,
which would make the code not very clean. You can remove this part and fix
truncate column in another PR, or fix that in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-58819971 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-58820059 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21673/consoleFull) for PR 2770 at commit [`e483547`](https://github.com/apache/spark/commit/e48354730645951e2fe2c485cab310df8033bf72). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-58821270 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21673/consoleFull) for PR 2770 at commit [`e483547`](https://github.com/apache/spark/commit/e48354730645951e2fe2c485cab310df8033bf72). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-58821272 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21673/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
GitHub user wangxiaojing opened a pull request: https://github.com/apache/spark/pull/2770 [spark-3907][sql] add truncate table support JIRA issue: [SPARK-3907]https://issues.apache.org/jira/browse/SPARK-3907 add turncate table support TRUNCATE TABLE table_name [PARTITION partition_spec]; partition_spec: : (partition_col = partition_col_value, partition_col = partiton_col_value, ...) Removes all rows from a table or partition(s). Currently target table should be native/managed table or exception will be thrown. User can specify partial partition_spec for truncating multiple partitions at once and omitting partition_spec will truncate all partitions in the table. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wangxiaojing/spark spark-3907 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2770.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2770 commit 77b1f2022d1a5b287fe43e9823f6d8b7934a969e Author: wangxiaojing u9j...@gmail.com Date: 2014-10-11T16:08:26Z add truncate table support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-58754916 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [spark-3907][sql] add truncate table support
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2770#issuecomment-58754918 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
