[GitHub] spark pull request: ALS implicit: added missing parameter alpha in...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3343#issuecomment-63945210 @felixmaximilian This was merged but Apache didn't close it automatically. Do you mind closing it? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: ALS implicit: added missing parameter alpha in...
Github user felixmaximilian closed the pull request at: https://github.com/apache/spark/pull/3343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: ALS implicit: added missing parameter alpha in...
GitHub user felixmaximilian opened a pull request: https://github.com/apache/spark/pull/3343 ALS implicit: added missing parameter alpha in doc string You can merge this pull request into a Git repository by running: $ git pull https://github.com/felixmaximilian/spark fix-documentation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/3343.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3343 commit 7d172bade856a7ffba42a55fc7a0dd1f3fb43eb8 Author: Felix Maximilian Möller felixmaximilian.moel...@immobilienscout24.de Date: 2014-11-18T10:24:15Z added missing parameter alpha in doc string. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: ALS implicit: added missing parameter alpha in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3343#issuecomment-63451099 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: ALS implicit: added missing parameter alpha in...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3343#discussion_r20499467
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -797,6 +797,7 @@ object ALS {
* @param rank number of features to use
* @param iterations number of iterations of ALS (recommended: 10-20)
* @param lambda regularization factor (recommended: 0.01)
+ * @param alpha confidence parameter (only applies when
immplicitPrefs = true)
--- End diff --
So, while we're here, maybe clean a few more things up. immplicit is
misspelled, and since this is documentation for `trainImplicit`, there is no
`implicitPrefs` parameter anyway. It's, erm, _implicitly_ true. But these were
just true in the text you copied, so can perhaps be fixed elsewhere.
It's really 1 + alpha*R that is the confidence value. alpha sort of
controls how difference confidence is in an observed and unobserved
interaction. Maybe it's nice to bother to explain a tiny bit more about what
this is, in the class scaladoc, and refer to it. While we're here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: ALS implicit: added missing parameter alpha in...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3343#issuecomment-63516863 LGTM. Merged into master and branch-1.2. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
