[GitHub] spark pull request: Fix Scala 2.11 compilation error in RDDInfo.sc...

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/9538#discussion_r44212577
  
--- Diff: core/src/main/scala/org/apache/spark/storage/RDDInfo.scala ---
@@ -28,20 +28,10 @@ class RDDInfo(
 val numPartitions: Int,
 var storageLevel: StorageLevel,
 val parentIds: Seq[Int],
-val callSite: CallSite,
+val callSite: CallSite = CallSite.empty,
--- End diff --

This is a reasonable way to address the compilation failure, but I think 
this is also changing the API in a binary-incompatible way? MiMa will tell us. 
If so then actually we will need the new constructor to not take a final 
optional arg. Or, adjust callers to not actually need the optional arg and use 
the existing constructor, passing empty if needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Fix Scala 2.11 compilation error in RDDInfo.sc...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9538#issuecomment-154712870
  
**[Test build #45283 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45283/consoleFull)**
 for PR 9538 at commit 
[`bfaf2d5`](https://github.com/apache/spark/commit/bfaf2d5351d3577b459af6c25ea043d3dcf6d73f).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:\n  * 
`class ExecutionMemoryPool(`\n  * `abstract class MemoryPool(lock: Object) `\n  
* `class StorageMemoryPool(lock: Object) extends MemoryPool(lock) with Logging 
`\n  * `class LDAModel(JavaModelWrapper, JavaSaveable, Loader):`\n


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Fix Scala 2.11 compilation error in RDDInfo.sc...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9538#issuecomment-154702642
  
**[Test build #45283 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45283/consoleFull)**
 for PR 9538 at commit 
[`bfaf2d5`](https://github.com/apache/spark/commit/bfaf2d5351d3577b459af6c25ea043d3dcf6d73f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Fix Scala 2.11 compilation error in RDDInfo.sc...

[jaceklaskowski]

Github user jaceklaskowski commented on the pull request:

https://github.com/apache/spark/pull/9538#issuecomment-154707778
  
It worked fine for me.

```
➜  spark git:(master) ✗ ./build/mvn -Pyarn -Phadoop-2.6 
-Dhadoop.version=2.7.1 -Dscala-2.11 -Phive -Phive-thriftserver -DskipTests 
clean install
...
[INFO] BUILD SUCCESS
```

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Fix Scala 2.11 compilation error in RDDInfo.sc...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9538#issuecomment-154712895
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Fix Scala 2.11 compilation error in RDDInfo.sc...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9538#issuecomment-154699687
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Fix Scala 2.11 compilation error in RDDInfo.sc...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9538#issuecomment-154699714
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Fix Scala 2.11 compilation error in RDDInfo.sc...

[tedyu]

GitHub user tedyu opened a pull request:

https://github.com/apache/spark/pull/9538

Fix Scala 2.11 compilation error in RDDInfo.scala

As shown in 
https://amplab.cs.berkeley.edu/jenkins/view/Spark-QA-Compile/job/Spark-Master-Scala211-Compile/1946/console
 , compilation fails with:
```
[error] 
/home/jenkins/workspace/Spark-Master-Scala211-Compile/core/src/main/scala/org/apache/spark/storage/RDDInfo.scala:25:
 in class RDDInfo, multiple overloaded alternatives of constructor RDDInfo 
define default arguments.
[error] class RDDInfo(
[error]   
```
This PR tries to fix the compilation error

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/spark master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/9538.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9538


commit bfaf2d5351d3577b459af6c25ea043d3dcf6d73f
Author: tedyu 
Date:   2015-11-07T12:54:06Z

Fix Scala 2.11 compilation error in RDDInfo.scala




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Fix Scala 2.11 compilation error in RDDInfo.sc...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/9538#issuecomment-154707413
  
CC @andrewor14 / 
https://github.com/apache/spark/commit/7f741905b06ed6d3dfbff6db41a3355dab71aa3c
@tedyu you should probably attach this to SPARK-2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Fix Scala 2.11 compilation error in RDDInfo.sc...

[tedyu]

Github user tedyu commented on the pull request:

https://github.com/apache/spark/pull/9538#issuecomment-154719077
  
MiMA check passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org