subject:"\[GitHub\] spark pull request\: Minor fix"

[GitHub] spark pull request: [MINOR] Fix Typos 'a -> an'

2016-05-26 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13317


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos 'a -> an'

2016-05-26 Thread rxin

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-222064507
  
Merging in master/2.0.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos 'a -> an'

2016-05-26 Thread holdenk

Github user holdenk commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221950905
  
So when I was skimming it last night, it looked like it also drops "a and" 
to "and" (which is good) but we might also want to mention.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread srowen

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221855988
  
As a grammar pedant, I approve, even though this is does end up touching a 
lot of files. It's helpful to just say in the title that the change is "a -> 
an" fixes but no big deal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221814415
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221814418
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59352/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221814174
  
**[Test build #59352 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59352/consoleFull)**
 for PR 13317 at commit 
[`230c801`](https://github.com/apache/spark/commit/230c80148cdcd29242fa8fb828ca12ec8c402221).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng

Github user zhengruifeng commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221803163
  
@holdenk Thanks. Good night.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread holdenk

Github user holdenk commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221802092
  
Oh I think the MiMa test failures are spurious. Personally I'm going to go 
to sleep and trigger a test again in the morning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng

Github user zhengruifeng commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221801013
  
@holdenk Excuse me,  How to deal with MiMa test failures? It seems caused 
by change in `core`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221796634
  
**[Test build #59357 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59357/consoleFull)**
 for PR 13317 at commit 
[`380fdea`](https://github.com/apache/spark/commit/380fdeaf5c5efde32b5f32b672f87b280a1c3eee).
 * This patch **fails MiMa tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221796650
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59357/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221796648
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng

Github user zhengruifeng commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221795573
  
@holdenk Yes. I use cmd like this `grep -in ' a [aeiou]' 
mllib/src/main/scala/org/apache/spark/ml/*/*scala` 
to generate potential wrong lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221794885
  
**[Test build #59357 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59357/consoleFull)**
 for PR 13317 at commit 
[`380fdea`](https://github.com/apache/spark/commit/380fdeaf5c5efde32b5f32b672f87b280a1c3eee).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread holdenk

Github user holdenk commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221793459
  
Also if this was created by a regex or similar it might be useful for 
review to also mention the rule that was applied to make the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng

Github user zhengruifeng commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221792040
  
@holdenk Thanks. I think you are right. I will revert `an one-xxx` to `a 
one-xxx`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread holdenk

Github user holdenk commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221791122
  
Also, your change seems to have made a few odd changes "an one way" which 
sounds odd, generally "a one way" is considered sounding "better" (I'm a bit 
fuzzy on the exact rule - but if you look you'll see people say "a one way 
ticket" instead of "an one way ticket" and some other similar things).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221791117
  
**[Test build #59352 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59352/consoleFull)**
 for PR 13317 at commit 
[`230c801`](https://github.com/apache/spark/commit/230c80148cdcd29242fa8fb828ca12ec8c402221).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng

Github user zhengruifeng commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221790963
  
@holdenk Thanks. I have fixed this. and run `lint-java` to check java file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread holdenk

Github user holdenk commented on a diff in the pull request:

https://github.com/apache/spark/pull/13317#discussion_r64698017
  
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -105,7 +105,7 @@ private[spark] abstract class MapOutputTracker(conf: 
SparkConf) extends Logging
 }
   }
 
-  /** Send a one-way message to the trackerEndpoint, to which we expect it 
to reply with true. */
+  /** Send an one-way message to the trackerEndpoint, to which we expect 
it to reply with true. */
--- End diff --

I don't think this change is correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread holdenk

Github user holdenk commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221790462
  
So it seems that in a few places adding the extra character has pushed it 
over the 100. You should probably run the linter explicitly if you have it 
disabled by default `./dev/lint-scala`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221789830
  
**[Test build #59351 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59351/consoleFull)**
 for PR 13317 at commit 
[`cff3aa8`](https://github.com/apache/spark/commit/cff3aa81f2417ff5bc0d1e7bf205ed2ff5a8eb7f).
 * This patch **fails Scala style tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221789832
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221789833
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59351/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13317#issuecomment-221789634
  
**[Test build #59351 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59351/consoleFull)**
 for PR 13317 at commit 
[`cff3aa8`](https://github.com/apache/spark/commit/cff3aa81f2417ff5bc0d1e7bf205ed2ff5a8eb7f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-26 Thread zhengruifeng

GitHub user zhengruifeng opened a pull request:

https://github.com/apache/spark/pull/13317

[MINOR] Fix Typos

## What changes were proposed in this pull request?

`a` -> `an`


## How was this patch tested?

local build





You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zhengruifeng/spark a_an

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13317.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13317


commit cff3aa81f2417ff5bc0d1e7bf205ed2ff5a8eb7f
Author: Zheng RuiFeng 
Date:   2016-05-26T06:29:10Z

create pr




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-19 Thread rxin

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-220521732
  
@srowen we should backport the doc fixes into branch-2.0.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-15 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13078


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-15 Thread srowen

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/13078#discussion_r63292985
  
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -64,8 +64,9 @@ private[ann] trait Layer extends Serializable {
* @return the layer model
*/
   def createModel(initialWeights: BDV[Double]): LayerModel
+
   /**
-   * Returns the instance of the layer with random generated weights
+   * Returns the instance of the layer with random generated weights.
--- End diff --

Yes, I see, but it just says "returns the layer model", which is what the 
text above already says in more detail. I didn't see a point in repeating it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218950522
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58537/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218950521
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218950439
  
**[Test build #58537 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58537/consoleFull)**
 for PR 13078 at commit 
[`9b2a5aa`](https://github.com/apache/spark/commit/9b2a5aa9f88cbb35a4843298a7c295297b4ce378).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218942530
  
**[Test build #58537 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58537/consoleFull)**
 for PR 13078 at commit 
[`9b2a5aa`](https://github.com/apache/spark/commit/9b2a5aa9f88cbb35a4843298a7c295297b4ce378).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread zhengruifeng

Github user zhengruifeng commented on a diff in the pull request:

https://github.com/apache/spark/pull/13078#discussion_r63128336
  
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -64,8 +64,9 @@ private[ann] trait Layer extends Serializable {
* @return the layer model
*/
   def createModel(initialWeights: BDV[Double]): LayerModel
+
   /**
-   * Returns the instance of the layer with random generated weights
+   * Returns the instance of the layer with random generated weights.
--- End diff --

This method already have a `@return` text.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread zhengruifeng

Github user zhengruifeng commented on a diff in the pull request:

https://github.com/apache/spark/pull/13078#discussion_r63128009
  
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/BreezeUtil.scala ---
@@ -55,7 +55,7 @@ private[ann] object BreezeUtil {
* @param y y
*/
   def dgemv(alpha: Double, a: BDM[Double], x: BDV[Double], beta: Double, 
y: BDV[Double]): Unit = {
-require(a.cols == x.length, "A & b Dimension mismatch!")
+require(a.cols == x.length, "A & x Dimension mismatch!")
--- End diff --

Right. I will rename the matrix args to upper and add this missing checking.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218834997
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58497/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218834995
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218834686
  
**[Test build #58497 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58497/consoleFull)**
 for PR 13078 at commit 
[`2d9a090`](https://github.com/apache/spark/commit/2d9a0900ec392f11efa1eebd45e412ca9c27226a).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218812765
  
**[Test build #58497 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58497/consoleFull)**
 for PR 13078 at commit 
[`2d9a090`](https://github.com/apache/spark/commit/2d9a0900ec392f11efa1eebd45e412ca9c27226a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread shaneknapp

Github user shaneknapp commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218811368
  
jenkins, test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread shaneknapp

Github user shaneknapp commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218809524
  
jenkins, test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread srowen

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/13078#discussion_r63038100
  
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/BreezeUtil.scala ---
@@ -55,7 +55,7 @@ private[ann] object BreezeUtil {
* @param y y
*/
   def dgemv(alpha: Double, a: BDM[Double], x: BDV[Double], beta: Double, 
y: BDV[Double]): Unit = {
-require(a.cols == x.length, "A & b Dimension mismatch!")
+require(a.cols == x.length, "A & x Dimension mismatch!")
--- End diff --

Y'know, while we're at it, the matrix args in this whole class don't match 
the docs. The arg here and similarly elsewhere can be called "A" not "a".

Also this should check that `A.rows == y.length` for consistency.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread srowen

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/13078#discussion_r63038154
  
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -64,8 +64,9 @@ private[ann] trait Layer extends Serializable {
* @return the layer model
*/
   def createModel(initialWeights: BDV[Double]): LayerModel
+
   /**
-   * Returns the instance of the layer with random generated weights
+   * Returns the instance of the layer with random generated weights.
--- End diff --

This could just become the `@return` text which is otherwise unuseful


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218780878
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread shaneknapp

Github user shaneknapp commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218781007
  
i will retrigger this build once maintenance is over.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218780880
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58488/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13078#issuecomment-218766614
  
**[Test build #58488 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58488/consoleFull)**
 for PR 13078 at commit 
[`2d9a090`](https://github.com/apache/spark/commit/2d9a0900ec392f11efa1eebd45e412ca9c27226a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix Typos

2016-05-12 Thread zhengruifeng

GitHub user zhengruifeng opened a pull request:

https://github.com/apache/spark/pull/13078

[MINOR] Fix Typos 

## What changes were proposed in this pull request?
Fix several typos in ML and SQL


## How was this patch tested?
manual tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zhengruifeng/spark fix_ann

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13078.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13078


commit b91920ba459ac785e62b6b7223ee1f9b57502d5b
Author: Zheng RuiFeng 
Date:   2016-05-09T13:31:49Z

create pr

commit 3369d3b2754b64169e569fd0fc647fb79ec0384e
Author: Zheng RuiFeng 
Date:   2016-05-09T13:35:34Z

fix one nit in ml-guide.md

commit 2d9a0900ec392f11efa1eebd45e412ca9c27226a
Author: Zheng RuiFeng 
Date:   2016-05-12T13:48:29Z

fix some typos in sql




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix newly added java-lint errors

2016-03-26 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201917668
  
Thank you, @srowen .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix newly added java-lint errors

2016-03-26 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/11968


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix newly added java-lint errors

2016-03-26 Thread srowen

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201785037
  
Merged to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix newly added java-lint errors

2016-03-25 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201604174
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54221/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix newly added java-lint errors

2016-03-25 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201604171
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix newly added java-lint errors

2016-03-25 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201603534
  
**[Test build #54221 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54221/consoleFull)**
 for PR 11968 at commit 
[`e11482a`](https://github.com/apache/spark/commit/e11482aaba0c11688671f228cfc6b930f9242d06).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix newly added java-lint errors

2016-03-25 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201598594
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix newly added java-lint errors

2016-03-25 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201598597
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54217/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix newly added java-lint errors

2016-03-25 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201597966
  
**[Test build #54217 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54217/consoleFull)**
 for PR 11968 at commit 
[`534b202`](https://github.com/apache/spark/commit/534b202e294ea1095f1c940f6c3af91a98d00145).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix newly added java-lint errors

2016-03-25 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201528990
  
**[Test build #54221 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54221/consoleFull)**
 for PR 11968 at commit 
[`e11482a`](https://github.com/apache/spark/commit/e11482aaba0c11688671f228cfc6b930f9242d06).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix newly added java-lint errors

2016-03-25 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201528379
  
@JoshRosen . Now, this PR only contains removing unused imports and fixing 
java-lint errors.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-192003831
  
Thank you, @srowen !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/11481


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread srowen

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-192001101
  
Merged to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191968452
  
Finally, it passed. 
I filed the Kinesis issue as 
[SPARK-13655](https://issues.apache.org/jira/browse/SPARK-13655), too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191960929
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52402/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191960926
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191960415
  
**[Test build #52402 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52402/consoleFull)**
 for PR 11481 at commit 
[`3cffee2`](https://github.com/apache/spark/commit/3cffee216291929184d4e73f7e4d5e88b54d20a4).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191896090
  
**[Test build #52402 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52402/consoleFull)**
 for PR 11481 at commit 
[`3cffee2`](https://github.com/apache/spark/commit/3cffee216291929184d4e73f7e4d5e88b54d20a4).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191894607
  
retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191893626
  
Thank you for confirming. I'll avoid that in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191876319
  
**[Test build #2608 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2608/consoleFull)**
 for PR 11481 at commit 
[`dd43417`](https://github.com/apache/spark/commit/dd434174c1f17bc0f26e0b3acbe9e21120d05265).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread srowen

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191811582
  
Yeah, I'm certain it's not this PR as it only changes a test name in the 
kinesis module. Something's wrong with the tests there. I'm not sure what do 
with this one; unless someone knows the problem and is fixing it, we can maybe 
just avoid fixing the files in kinesis and sort out the test separately


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191762447
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191762449
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52389/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191762388
  
**[Test build #52389 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52389/consoleFull)**
 for PR 11481 at commit 
[`dd43417`](https://github.com/apache/spark/commit/dd434174c1f17bc0f26e0b3acbe9e21120d05265).
 * This patch **fails from timeout after a configured wait of \`250m\`**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191672931
  
**[Test build #52389 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52389/consoleFull)**
 for PR 11481 at commit 
[`dd43417`](https://github.com/apache/spark/commit/dd434174c1f17bc0f26e0b3acbe9e21120d05265).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread srowen

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191671137
  
Jenkins, test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191670305
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191670308
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52369/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-03 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191670172
  
**[Test build #52369 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52369/consoleFull)**
 for PR 11481 at commit 
[`dd43417`](https://github.com/apache/spark/commit/dd434174c1f17bc0f26e0b3acbe9e21120d05265).
 * This patch **fails from timeout after a configured wait of \`250m\`**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191633263
  
Hi, @sarutak and @rxin .
three builds hanged at the same test 
**WithAggregationKinesisBackedBlockRDDSuite**.
The first build fails due to timeout, the others seems to fail with the 
same reason.

I'm not sure this is the case for the followings? Or, any other reason?
  1. File a JIRA issue for **WithAggregationKinesisBackedBlockRDDSuite**
  2. Pass the test by removing the typo fix on Kinesis-related files
* KinesisBackedBlockRDDSuite.scala
* KinesisReceiverSuite.scala

I think it is out of this PR's scope to fix 
`WithAggregationKinesisBackedBlockRDDSuite`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191597133
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191597134
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52348/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191597050
  
**[Test build #52348 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52348/consoleFull)**
 for PR 11481 at commit 
[`dd43417`](https://github.com/apache/spark/commit/dd434174c1f17bc0f26e0b3acbe9e21120d05265).
 * This patch **fails from timeout after a configured wait of \`250m\`**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191588479
  
Thank you for your advice!
Is the magic word of a committer **Jenkins, test this please** and **ok to 
test** then?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191586618
  
**[Test build #52369 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52369/consoleFull)**
 for PR 11481 at commit 
[`dd43417`](https://github.com/apache/spark/commit/dd434174c1f17bc0f26e0b3acbe9e21120d05265).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread sarutak

Github user sarutak commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191586570
  
@dongjoon-hyun Once a commiter trigger a test, you can trigger another one 
by yourself in the same PR by saying like "retest this please" .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191582841
  
Oh, thank you for re-triggering.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191577833
  
**[Test build #2604 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2604/consoleFull)**
 for PR 11481 at commit 
[`dd43417`](https://github.com/apache/spark/commit/dd434174c1f17bc0f26e0b3acbe9e21120d05265).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191577290
  
Hi, @sarutak and @rxin .

**WithAggregationKinesisBackedBlockRDDSuite** took about 2 hours and still 
is running.
The following is the last part of Jenkins logs. It seems abnormal. Could 
you trigger another test run please?
```
[info] WithAggregationKinesisBackedBlockRDDSuite:
Using endpoint URL https://kinesis.us-west-2.amazonaws.com for creating 
Kinesis streams for tests.
[2016-03-02 18:39:50.670894] [0x7f2565bb6700] [info] 
[kinesis_producer.cc:79] Created pipeline for stream 
"KinesisTestUtils-2198454940508828809"
[2016-03-02 18:39:50.671040] [0x7f2565bb6700] [info] [shard_map.cc:83] 
Updating shard map for stream "KinesisTestUtils-2198454940508828809"
[2016-03-02 18:39:50.929527] [0x7f25647b4700] [info] [shard_map.cc:163] 
Successfully updated shard map for stream 
"KinesisTestUtils-2198454940508828809" found 2 shards
[info] - Basic reading from Kinesis (2 seconds, 186 milliseconds)
[info] - Read data available in both block manager and Kinesis (77 
milliseconds)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191551076
  
Thank you, @sarutak and @rxin !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread rxin

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191538377
  
LGTM pending tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread SparkQA

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191536743
  
**[Test build #52348 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52348/consoleFull)**
 for PR 11481 at commit 
[`dd43417`](https://github.com/apache/spark/commit/dd434174c1f17bc0f26e0b3acbe9e21120d05265).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread sarutak

Github user sarutak commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191535651
  
ok to test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread AmplabJenkins

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191534879
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun

Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11481#issuecomment-191534769
  
Since it's not about documents and contains testcase name typo, so I 
couldn't choose `DOCS` as component name. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix typos in comments and testcase nam...

2016-03-02 Thread dongjoon-hyun

GitHub user dongjoon-hyun opened a pull request:

https://github.com/apache/spark/pull/11481

[MINOR] Fix typos in comments and testcase name of code

## What changes were proposed in this pull request?

This PR fixes typos in comments and testcase name of code.

## How was this patch tested?

manual.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dongjoon-hyun/spark minor_fix_typos_in_code

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/11481.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11481


commit dd434174c1f17bc0f26e0b3acbe9e21120d05265
Author: Dongjoon Hyun 
Date:   2016-02-26T08:05:05Z

[MINOR] Fix typos in comments and testcase name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix for BUILD FAILURE for Scala 2.11

2016-01-07 Thread cloud-fan

Github user cloud-fan commented on a diff in the pull request:

https://github.com/apache/spark/pull/10636#discussion_r49049305
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONRelation.scala
 ---
@@ -68,29 +68,12 @@ private[sql] class JSONRelation(
 val maybeDataSchema: Option[StructType],
 val maybePartitionSpec: Option[PartitionSpec],
 override val userDefinedPartitionColumns: Option[StructType],
-override val bucketSpec: Option[BucketSpec],
+override val bucketSpec: Option[BucketSpec] = None,
 override val paths: Array[String] = Array.empty[String],
 parameters: Map[String, String] = Map.empty[String, String])
 (@transient val sqlContext: SQLContext)
   extends HadoopFsRelation(maybePartitionSpec, parameters) {
 
-  def this(
-  inputRDD: Option[RDD[String]],
-  maybeDataSchema: Option[StructType],
-  maybePartitionSpec: Option[PartitionSpec],
-  userDefinedPartitionColumns: Option[StructType],
-  paths: Array[String] = Array.empty[String],
-  parameters: Map[String, String] = Map.empty[String, 
String])(sqlContext: SQLContext) = {
--- End diff --

scala 2.11 doesn't support override curry constructor?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix for BUILD FAILURE for Scala 2.11

2016-01-07 Thread jaceklaskowski

Github user jaceklaskowski commented on a diff in the pull request:

https://github.com/apache/spark/pull/10636#discussion_r49051693
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONRelation.scala
 ---
@@ -68,29 +68,12 @@ private[sql] class JSONRelation(
 val maybeDataSchema: Option[StructType],
 val maybePartitionSpec: Option[PartitionSpec],
 override val userDefinedPartitionColumns: Option[StructType],
-override val bucketSpec: Option[BucketSpec],
+override val bucketSpec: Option[BucketSpec] = None,
 override val paths: Array[String] = Array.empty[String],
 parameters: Map[String, String] = Map.empty[String, String])
 (@transient val sqlContext: SQLContext)
   extends HadoopFsRelation(maybePartitionSpec, parameters) {
 
-  def this(
-  inputRDD: Option[RDD[String]],
-  maybeDataSchema: Option[StructType],
-  maybePartitionSpec: Option[PartitionSpec],
-  userDefinedPartitionColumns: Option[StructType],
-  paths: Array[String] = Array.empty[String],
-  parameters: Map[String, String] = Map.empty[String, 
String])(sqlContext: SQLContext) = {
--- End diff --

The error message was:

```
[error] 
/Users/jacek/dev/oss/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONRelation.scala:66:
in class JSONRelation, multiple overloaded alternatives of constructor
JSONRelation define default arguments.
[error] private[sql] class JSONRelation(
[error]^
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MINOR] Fix for BUILD FAILURE for Scala 2.11

2016-01-07 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10636


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

1 2 3 4 >

1 - 100 of 391 matches

Mail list logo