[GitHub] spark pull request: Remove duplicate implementation of compute in ...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12747#issuecomment-215276645
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: Remove duplicate implementation of compute in ...

2016-04-27 Thread dding3
GitHub user dding3 opened a pull request:

https://github.com/apache/spark/pull/12747

Remove duplicate implementation of compute in LogisticGradient

## What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

This PR removes duplicate implementation of compute in LogisticGradient 
class


## How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration 
tests, manual tests)

unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, 
remove this)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dding3/spark master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12747.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12747


commit a88b7f40eb6e363de8e530a2e377d6027cb91b16
Author: dding3 
Date:   2016-04-26T08:31:28Z

remove unnecessary compute method in LogisticGRadient

commit 3695a52b7e3d7e95cbc0ec30ea8a76da53d59a70
Author: dding3 
Date:   2016-04-26T08:33:08Z

Merge branch 'upstream_master'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org