[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread ash211 
Github user ash211 commented on the pull request:

https://github.com/apache/spark/pull/1119#issuecomment-46502519
  
Dorx, can you add what IDE that was to the below ticket?  Thanks!

https://issues.apache.org/jira/browse/SPARK-2182


On Wed, Jun 18, 2014 at 6:18 PM, Andrew Ash  wrote:

> Agreed, I'll file a ticket about it
>
>
> On Wed, Jun 18, 2014 at 6:07 PM, dorx  wrote:
>
>> @ash211  FWIW they have other unicode
>> operators supported in addition to ⇒:
>> http://www.scala-lang.org/old/node/4723
>> Might want to look into adding a no-unicode-char rule in scalastyle.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> .
>>
>
>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread ash211 
Github user ash211 commented on the pull request:

https://github.com/apache/spark/pull/1119#issuecomment-46501874
  
Agreed, I'll file a ticket about it


On Wed, Jun 18, 2014 at 6:07 PM, dorx  wrote:

> @ash211  FWIW they have other unicode
> operators supported in addition to ⇒:
> http://www.scala-lang.org/old/node/4723
> Might want to look into adding a no-unicode-char rule in scalastyle.
>
> —
> Reply to this email directly or view it on GitHub
> .
>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread dorx 
Github user dorx commented on the pull request:

https://github.com/apache/spark/pull/1119#issuecomment-46500757
  
@ash211 FWIW they have other unicode operators supported in addition to 
⇒: http://www.scala-lang.org/old/node/4723
Might want to look into adding a no-unicode-char rule in scalastyle.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/1119


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread rxin 
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/1119#issuecomment-46500211
  
Thanks. I've merged this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread ash211 
Github user ash211 commented on the pull request:

https://github.com/apache/spark/pull/1119#issuecomment-46499283
  
That even works in Scala?  I definitely didn't intend to commit that as a 
single Unicode character as opposed to two characters -- an '=' and a '>' and 
code in Vim which I wouldn't expect to do character replacement, but who knows.

Definitely replace it with => 

+1 LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1119#issuecomment-46496224
  
Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1119#issuecomment-46496228
  
All automated tests passed.
Refer to this link for build results: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15882/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread rxin 
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/1119#issuecomment-46492402
  
@ash211 ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1119#issuecomment-46489748
  
Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1119#issuecomment-46489719
  
 Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread dorx 
Github user dorx commented on the pull request:

https://github.com/apache/spark/pull/1119#issuecomment-46489650
  
@ash211 @rxin @mengxr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Remove unicode operator from RDD.scala

2014-06-18 Thread dorx 
GitHub user dorx opened a pull request:

https://github.com/apache/spark/pull/1119

Remove unicode operator from RDD.scala

Some IDEs don’t support unicode characters in source code. Check if this 
breaks binary compatibility.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dorx/spark unicode

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/1119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1119


commit 05618c3ce84600ae5a57767197988559f76d00f6
Author: Doris Xin 
Date:   2014-06-18T20:24:23Z

Remove unicode operator from RDD.scala

Some IDEs don’t support unicode characters in source code




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---