[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-182283459 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-181824962 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-181829682 **[Test build #50970 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50970/consoleFull)** for PR 9532 at commit [`80dcf1f`](https://github.com/apache/spark/commit/80dcf1f3ec6883426918cf9aa24c3a3c8e9f788a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-181870074 **[Test build #50970 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50970/consoleFull)** for PR 9532 at commit [`80dcf1f`](https://github.com/apache/spark/commit/80dcf1f3ec6883426918cf9aa24c3a3c8e9f788a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-181870383 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-181870386 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50970/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180977355 Yeah, this is what I saw too. It's not a problem with the build of the code itself, since as you say it passes locally. It's a problem that occurs when MiMa builds previous code to evaluate API differences. I didn't quite understand the fix. Your change is a clue; it may relate to Maven's closest-first dependency rules. In that case, I suspect the right place to add the explicit dependency is in `sql`, not `core`. That's where it used so technically this must be declared. In any event you don't need to repeat the version, and in fact should not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-181040402 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-181040335 **[Test build #50901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50901/consoleFull)** for PR 9532 at commit [`80dcf1f`](https://github.com/apache/spark/commit/80dcf1f3ec6883426918cf9aa24c3a3c8e9f788a). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-181040403 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50901/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-181021315 **[Test build #50901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50901/consoleFull)** for PR 9532 at commit [`80dcf1f`](https://github.com/apache/spark/commit/80dcf1f3ec6883426918cf9aa24c3a3c8e9f788a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-181051318 @srowen Two tests failed with timeout. Unrelated? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-181075550 Yes this test is bad at the moment. Good news is it got past MiMa tests, I think. The change looks right to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180853555 @srowen Yes I removed the pom.xml reference, and was successful building locally. Maven dependencies might have changed since I initially issued the patch ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180854108 **[Test build #50877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50877/consoleFull)** for PR 9532 at commit [`56f32b4`](https://github.com/apache/spark/commit/56f32b4099c4c14cd81456deb41b0eddd233262a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180860193 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180867438 OK, back to my initial confusion on this. So the pom.xml change is needed to make this work ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180860184 **[Test build #50877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50877/consoleFull)** for PR 9532 at commit [`56f32b4`](https://github.com/apache/spark/commit/56f32b4099c4c14cd81456deb41b0eddd233262a). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180860194 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50877/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180826713 @gliptak yes obviously. But as per several comments in this discussion, I still don't see why you added the pom stanzas that you did. I think these should be removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180826210 The deprecated call was updated with this commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180816087 Back online now. Actually, `commons-codec` is already declared at version 1.10 in the parent `pom.xml`. At this stage, we only need to change the deprecated call right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-177531066 I think it is a necessary part of removing the deprecated call so that it works reliably? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-177521123 @srowen if you are proposed changing dependencies, would a follow-up JIRA work for that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-176916226 I see (not in front of the code now) - should just be an edit to that section then. Not a new declaration in core. The change is in SQL anyway --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-176486910 @srowen commons-codec is already in the section --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-176154928 **[Test build #50273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50273/consoleFull)** for PR 9532 at commit [`a22b0b8`](https://github.com/apache/spark/commit/a22b0b869cf6a68c0ae22a91a35ebd0a19f1e8a8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-176186278 I'm sort of surprised that it was not necessary to update the file listing all of the project dependencies? The change is looking fairly good, except that the version needs to be managed in `dependencyManagement` in the parent POM. If the `sql` module does not already depend on `commons-codec` it needs to, but `core` does not need a change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-176155359 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-176155365 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50273/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-176113342 **[Test build #50273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50273/consoleFull)** for PR 9532 at commit [`a22b0b8`](https://github.com/apache/spark/commit/a22b0b869cf6a68c0ae22a91a35ebd0a19f1e8a8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-176103990 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-175927249 Github is hiccuping ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-175516848 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-175509139 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-175516852 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50188/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-174335388 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-174336337 **[Test build #49957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49957/consoleFull)** for PR 9532 at commit [`a22b0b8`](https://github.com/apache/spark/commit/a22b0b869cf6a68c0ae22a91a35ebd0a19f1e8a8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-174351460 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49957/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-174351459 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-174351394 **[Test build #49957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49957/consoleFull)** for PR 9532 at commit [`a22b0b8`](https://github.com/apache/spark/commit/a22b0b869cf6a68c0ae22a91a35ebd0a19f1e8a8). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-174175906 These tests are failing everywhere, it's not related --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-174032690 Two failed tests org.apache.spark.sql.hive.ParquetMetastoreSuite.Caching converted data source Parquet Relations0.25 sec5 org.apache.spark.sql.hive.execution.HiveExplainSuite.explain create table command 11 ms 5 Possibly unrelated? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-174008158 **[Test build #2443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2443/consoleFull)** for PR 9532 at commit [`a22b0b8`](https://github.com/apache/spark/commit/a22b0b869cf6a68c0ae22a91a35ebd0a19f1e8a8). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-173959296 **[Test build #2439 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2439/consoleFull)** for PR 9532 at commit [`a22b0b8`](https://github.com/apache/spark/commit/a22b0b869cf6a68c0ae22a91a35ebd0a19f1e8a8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-173980067 **[Test build #2439 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2439/consoleFull)** for PR 9532 at commit [`a22b0b8`](https://github.com/apache/spark/commit/a22b0b869cf6a68c0ae22a91a35ebd0a19f1e8a8). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-173986122 **[Test build #2443 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2443/consoleFull)** for PR 9532 at commit [`a22b0b8`](https://github.com/apache/spark/commit/a22b0b869cf6a68c0ae22a91a35ebd0a19f1e8a8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-173609858 @gliptak are you able to follow up on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-173769068 **[Test build #49896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49896/consoleFull)** for PR 9532 at commit [`a22b0b8`](https://github.com/apache/spark/commit/a22b0b869cf6a68c0ae22a91a35ebd0a19f1e8a8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-173770249 @srowen This built locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-173802601 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-173802510 **[Test build #49896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49896/consoleFull)** for PR 9532 at commit [`a22b0b8`](https://github.com/apache/spark/commit/a22b0b869cf6a68c0ae22a91a35ebd0a19f1e8a8). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-173802603 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49896/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-172239732 Right now the issues seem to be: you're duplicating the version info in child POMs, and adding exclusions that probably aren't needed. Transitive dependencies are managed up by Maven. Version 1.10 seems OK to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-172238584 Would you like me to update this patch with 1.7? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-171405117 (you meant "You can try managing it up to version 1.7"?) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-171396291 @yhuai in the past, the problem was that it then fails when an older version is provided by old Hadoop 1.x at runtime. Hadoop 2.2+ has a recent enough version (1.7). However I encountered a problem with how MiMa executes when trying to change this that I didn't fully understand. You can try managing it up to version 1.10 and see the problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-171405897 I was figuring go all the way, but sure, 1.7 is a little more conservative. The Commons libraries don't tend to remove old deprecated methods, which would be the problem in updating past 1.7. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-171393354 @srowen Looks like hadoop is not using the same version of common-code? Should we bump the version of `commons-codec` just for using sha1Hex()? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-156487704 @srowen Can you offer some pointers on how to move this forward? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-156503441 Hm, I still think you don't want to duplicate the version info. I'm surprised if you have to exclude and then add dependencies to get SBT working. What about only depending on the component directly? No exclusion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-156504764 @srowen I'm working this using ```mvn``` I will remove one of the excludes to bring the dependency back (without direct reference) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-155643110 https://github.com/apache/spark/pull/3864 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on a diff in the pull request: https://github.com/apache/spark/pull/9532#discussion_r44494766 --- Diff: core/pom.xml --- @@ -78,11 +84,23 @@ net.java.dev.jets3t jets3t + + + commons-codec + commons-codec + + org.apache.curator curator-recipes + + + commons-codec + commons-codec + 1.10 --- End diff -- Without this, the other exclusions drop commons-codec. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-155067478 @srowen So you are seeing this as a side effect if the Maven dependency changes ... I will work this some more (locally). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on a diff in the pull request: https://github.com/apache/spark/pull/9532#discussion_r44275653 --- Diff: core/pom.xml --- @@ -78,11 +84,23 @@ net.java.dev.jets3t jets3t + + + commons-codec + commons-codec + + org.apache.curator curator-recipes + + + commons-codec + commons-codec + 1.10 --- End diff -- The reason to bring it in directly is those exclusions above. I will validate thus once more. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154842126 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154842130 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154806109 That doesn't sound right. Is it stuck somewhere? alternatively you might be able to deduce the problem with `mvn -Dverbose dependency:tree` as it will show you what older versions are being replaced with newer versions, and you might see where a version < 1.6 is coming in and needs to be excluded explicitly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154846299 **[Test build #45303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45303/consoleFull)** for PR 9532 at commit [`7b7e075`](https://github.com/apache/spark/commit/7b7e07535cb5c76bdb049f06492eed7985c1b1e6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154851750 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154851731 **[Test build #45303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45303/consoleFull)** for PR 9532 at commit [`7b7e075`](https://github.com/apache/spark/commit/7b7e07535cb5c76bdb049f06492eed7985c1b1e6). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154853134 @srowen Which maven pom.xml this corresponds to (streaming?)? [error] (streaming-kinesis-asl-assembly/*:update) java.lang.IllegalStateException: impossible to get artifacts when data has not been loaded. IvyNode = commons-codec#commons-codec;1.4 [error] (streaming-kafka-assembly/*:update) java.lang.IllegalStateException: impossible to get artifacts when data has not been loaded. IvyNode = commons-codec#commons-codec;1.4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154871551 These are in `extras`, and `external`, respectively. That's a strange error, but you may be onto something. What does `mvn -Dverbose dependency:tree` show over here? old versions of codec being replaced? that's what we may have to patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154890563 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154890556 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154891069 **[Test build #45323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45323/consoleFull)** for PR 9532 at commit [`7528029`](https://github.com/apache/spark/commit/7528029cc1c28e65cdbbf175bf6bddb40cc5c75e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154901842 **[Test build #45323 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45323/consoleFull)** for PR 9532 at commit [`7528029`](https://github.com/apache/spark/commit/7528029cc1c28e65cdbbf175bf6bddb40cc5c75e). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154901871 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154905851 Number of errors related to signatures: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45323/testReport/org.apache.spark/JavaAPISuite/reduce/ ``` Error Message class "javax.servlet.FilterRegistration"'s signer information does not match signer information of other classes in the same package Stacktrace sbt.ForkMain$ForkError: class "javax.servlet.FilterRegistration"'s signer information does not match signer information of other classes in the same package at java.lang.ClassLoader.checkCerts(ClassLoader.java:952) at java.lang.ClassLoader.preDefineClass(ClassLoader.java:666) at java.lang.ClassLoader.defineClass(ClassLoader.java:794) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:449) ``` Something got reordered with the pom.xml modifications? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9532#discussion_r44245483 --- Diff: core/pom.xml --- @@ -78,11 +84,23 @@ net.java.dev.jets3t jets3t + + + commons-codec + commons-codec + + org.apache.curator curator-recipes + + + commons-codec + commons-codec + 1.10 --- End diff -- You don't need to re-declare the dependency and indeed don't want to; you're duplicating version info --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154970102 That means something is bringing in `javax.servlet` now, which must be excluded because it resists repackaging. It's a rabbit hole; it'd be great to bottom out as that might be it. In the worst case we might have to give up on this as an example of how SBT doesn't resolve things the same way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154712523 @gliptak you can ignore that, it's indeed a false positive. The problem is the compilation error. Yes, the problem is the SBT build, not Maven, as expected. You'd have to investigate why the SBT dep resolution differs and adjust exclusions. It's annoying but this is the price of trying to make SBT work as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154712261 @srowen From SparkQA: "This patch adds the following public classes (experimental):" I do not see how my change adds a public class ... As for the compile error, it does build with ``mvn``` locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154653067 Eh, the line you changed doesn't compile. It seems quite directly related! But yes the question is why indeed. Does it compile for you with Maven? then we may have a Maven/SBT resolution difference again and you are getting older Codec from Hadoop probably in the SBT build. You may have to adjust dependencies to force some component to not bring in its version of Codec. I think this is why I wasn't able to change this before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154770983 @srowen I'm running ```build/sbt dependency-tree``` and it is literally running for several hours now. Is there an easier way to work this (or is there something to correct in my setup)? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154585515 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154585547 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154594465 The error message displayed seems to have no relation to the pull request change ... The compile does fail with: [error] /home/jenkins/workspace/SparkPullRequestBuilder/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala:127: value sha1Hex is not a member of object org.apache.commons.codec.digest.DigestUtils [error] UTF8String.fromString(DigestUtils.sha1Hex(input.asInstanceOf[Array[Byte]])) [error] ^ [error] one error found although ```1.10``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
GitHub user gliptak opened a pull request: https://github.com/apache/spark/pull/9532 SPARK-11565 Replace deprecated DigestUtils.shaHex call You can merge this pull request into a Git repository by running: $ git pull https://github.com/gliptak/spark SPARK-11565 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/9532.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9532 commit 5e2370ce455267e8bb2584704483e46c85b75b7d Author: Gábor LiptákDate: 2015-11-07T00:22:07Z SPARK-11565 Replace deprecated DigestUtils.shaHex call --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154587630 **[Test build #45273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45273/consoleFull)** for PR 9532 at commit [`5e2370c`](https://github.com/apache/spark/commit/5e2370ce455267e8bb2584704483e46c85b75b7d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154590892 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154590869 **[Test build #45273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45273/consoleFull)** for PR 9532 at commit [`5e2370c`](https://github.com/apache/spark/commit/5e2370ce455267e8bb2584704483e46c85b75b7d). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * `abstract class Writer extends BaseReadWrite `\n * `trait Writable `\n * `abstract class Reader[T] extends BaseReadWrite `\n * `trait Readable[T] `\n * `case class GetInternalRowField(child: Expression, ordinal: Int, dataType: DataType)`\n * `case class Expand(`\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org