[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-03-23 Thread squito
Github user squito closed the pull request at:

https://github.com/apache/spark/pull/4048


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-03-16 Thread squito
Github user squito commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-81738160
  
ping

Are others ambivalent about this, eg. maybe because of the complexity it 
introduces to the build?  If there isn't any more interest in this I'll just 
close it in a couple days.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-02-23 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-75604198
  
  [Test build #27859 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27859/consoleFull)
 for   PR 4048 at commit 
[`a1f1665`](https://github.com/apache/spark/commit/a1f16654a77caa3ef2e35d7e3ace830aa1708bdd).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-75620113
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27859/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-02-23 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-75620098
  
  [Test build #27859 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27859/consoleFull)
 for   PR 4048 at commit 
[`a1f1665`](https://github.com/apache/spark/commit/a1f16654a77caa3ef2e35d7e3ace830aa1708bdd).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `  case class Params(`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-26 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-71524664
  
  [Test build #26101 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26101/consoleFull)
 for   PR 4048 at commit 
[`9f125ee`](https://github.com/apache/spark/commit/9f125ee80e974d4b2cf56818efb60dfb40f1d564).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-71524670
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26101/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-26 Thread squito
Github user squito commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-71512674
  
I figured out the magic combination to make sbt, scalatest, junit, and the 
sbt-pom-reader all play nicely together.  I had to introduce a new config (or 
scope or something, sbt terminology still baffles me ...) instead of creating a 
new task.  Now you can run `unit:test` (or any other variant you like, eg 
`~unit:testQuick`) which will exclude everything tagged as an IntegrationTest.  
There is both a tag for scalatests, and a category for junit tests.

I've still only bothered with the tagging in core.  But I think this can be 
merged as is in any case -- this does the setup so someone more familiar w/ the 
other projects can figure out what to tag.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-71511628
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26100/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-26 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-71511623
  
  [Test build #26100 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26100/consoleFull)
 for   PR 4048 at commit 
[`2d6b733`](https://github.com/apache/spark/commit/2d6b733acce37802ac416ef14400b61f116d3aa3).
 * This patch **fails RAT tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-26 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-71511610
  
  [Test build #26100 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26100/consoleFull)
 for   PR 4048 at commit 
[`2d6b733`](https://github.com/apache/spark/commit/2d6b733acce37802ac416ef14400b61f116d3aa3).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-26 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-71512525
  
  [Test build #26101 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26101/consoleFull)
 for   PR 4048 at commit 
[`9f125ee`](https://github.com/apache/spark/commit/9f125ee80e974d4b2cf56818efb60dfb40f1d564).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-16 Thread squito
Github user squito commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70292578
  
@pwendell I like the idea of just getting tests to run faster in general, 
but I think its gonna be hard to make that happen.  (Not the most exciting 
tasks for beginners and I think the experienced folks have their hands full 
...)  This was meant to be an easy way to have some useful subset of tests 
that developers can run locally.  Its great that we have jenkins running tests 
automatically, but I'd really like to improve the local development process.

Even if we do speed up the other tests, I think there are always going to 
be some tests that fall into this bucket that we'd like to run, so I think this 
will still be useful.  But I agree that we the tests could be sped up a lot -- 
I made some notes on the JIRA about how even after this, eliminating (or 
speeding up) a small number of tests would have huge gains.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-16 Thread pwendell
Github user pwendell commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70300365
  
@squito yeah for sure, I think it's nice to have some set of integration 
tests that are flagged as such. I was just suggesting other ways we can improve 
our tests as well.

I wouldn't give up so easily on making `local-cluster` faster though... I 
don't think anyone has looked into optimizing it recently, and it's a common 
mechanism used by all tests, so if we improve the launch time then it will 
speed things up across the board. Also, there are other efforts around test 
parallelization that are ongoing which will speed up the runtime.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-15 Thread squito
Github user squito commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70181484
  
so, this doesn't actually work quite the way I wanted it to.  It turns out 
its skipping all the Junit tests as well.  The junit tests are run if you run 
with `test-only * -- -l`, but as sound as you add a tag like `test-only * -- -l 
foo`, then all the junit tests are skipped.  From the [junit-interface 
docs](https://github.com/sbt/junit-interface) Any parameter not starting with 
- or + is treated as a glob pattern for matching tests.

I will look into a solution for this, but I have a feeling this might mean 
we can't mix junit w/ the tagging approach, and we have to go to a more 
standard directory / filenaming approach to separating out integration tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-15 Thread pwendell
Github user pwendell commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70212728
  
@squito another thing is that we should look at whether these tests really 
need to be integration style tests or not. I've seen people often use 
`local-cluster` because it's easier to write as an integration test, even if 
they just put more effort in they could write a proper unit test.

Alternatively we could try and see if we can run these `local-cluster` 
tests more quickly in general. I don't think anyone has tried to optimize the 
execution time of that test path much.

In an ideal world the vast majority of our tests would actually be unit 
tests - i.e. they would run in milliseconds, so that we can have thousands of 
tests and have them run in a reasonable amount of time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread squito
Github user squito commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-69990018
  
oh good point Marcelo -- I forgot to add that I've only done this for 
`core` in this PR.  I wanted to ask others whether its worthwhile to do in 
other projects or not before I go digging into each one of them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread vanzin
Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-69990485
  
IIRC there are a few tests under `sql/` that use local-cluster too, but 
can't name any from the top of my head.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread pwendell
Github user pwendell commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-69991447
  
Just curious - what is the before and after time? I.e. what fraction of 
time does this cut down on?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread srowen
Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-69997514
  
This is not a terribly useful observation, but, this is what `surefire` vs 
`failsafe` is for in the Maven world, without making a custom mechanism. But we 
have the SBT build too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-69988559
  
  [Test build #25563 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25563/consoleFull)
 for   PR 4048 at commit 
[`3a85032`](https://github.com/apache/spark/commit/3a8503227d53554155e5766ce12d48039854f163).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-69988571
  
  [Test build #25563 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25563/consoleFull)
 for   PR 4048 at commit 
[`3a85032`](https://github.com/apache/spark/commit/3a8503227d53554155e5766ce12d48039854f163).
 * This patch **fails RAT tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread vanzin
Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-69988816
  
Hey Imran, haven't looked at the code, but `YarnClusterSuite` could 
probably use this tag too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-69988574
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25563/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70017553
  
  [Test build #25578 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25578/consoleFull)
 for   PR 4048 at commit 
[`70547fa`](https://github.com/apache/spark/commit/70547fa2311fb19072489202ae192cd214223a22).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70024397
  
  [Test build #25578 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25578/consoleFull)
 for   PR 4048 at commit 
[`70547fa`](https://github.com/apache/spark/commit/70547fa2311fb19072489202ae192cd214223a22).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70024404
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25578/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread squito
Github user squito commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70008794
  
@pwendell To be honest I'd never had the patience to run all the tests 
before on my laptop.  But I just tried them both again: 237 seconds vs. 852 
seconds (just for core), so these tests are down to ~25% of the total time.  It 
makes using `test-quick` a reality, while I have no end of complaints about 
sbt, I really like `test-quick`.

@vanzin yeah there are also a bunch of tests in other projects, I know 
there are a bunch in mllib as well.  (I guess this is really a WIP at this 
point, wanted to see if I folks like the idea before I do it in other projects.)

@srowen I wasn't familiar with `surefire` or `failsafe` from maven, but I 
figured there was some other way to just support an integration test 
separation.  I am just more familiar with tagging tests, and I think it buys us 
some more flexibility.  I'll see if I can figure out how to setup a maven task 
(or whatever its called) to only run the unit tests, but I know very little 
about maven ...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70008254
  
  [Test build #25576 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25576/consoleFull)
 for   PR 4048 at commit 
[`70547fa`](https://github.com/apache/spark/commit/70547fa2311fb19072489202ae192cd214223a22).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70015071
  
  [Test build #25576 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25576/consoleFull)
 for   PR 4048 at commit 
[`70547fa`](https://github.com/apache/spark/commit/70547fa2311fb19072489202ae192cd214223a22).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70015079
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25576/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4746 make it easy to skip IntegrationTes...

2015-01-14 Thread squito
Github user squito commented on the pull request:

https://github.com/apache/spark/pull/4048#issuecomment-70017200
  
Jenkins, retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org