[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-132563477 **[Test build #41231 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41231/console)** for PR 7874 at commit [`764a7ba`](https://github.com/apache/spark/commit/764a7ba319327b7f7e26140ad33213762acc99fc) after a configured wait of `175m`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-132563638 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41231/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7874 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-132561008 [Test build #1667 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1667/console) for PR 7874 at commit [`5a7b761`](https://github.com/apache/spark/commit/5a7b761ce2ffa5458d773cbe3cf77da778f6a6fa). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-132563634 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user darkjh commented on a diff in the pull request: https://github.com/apache/spark/pull/7874#discussion_r37393145 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -118,9 +118,11 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli * Can be generated using [[org.apache.spark.scheduler.InputFormatInfo.computePreferredLocations]] * from a list of input files or InputFormats for the application. */ + @Deprecated(Passing in preferred locations has no effect at all, see SPARK-8949, 1.5.0) --- End diff -- Thanks @srowen I wasn't aware of the different decorators. It's done now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-132500919 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-132501190 [Test build #1667 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1667/consoleFull) for PR 7874 at commit [`5a7b761`](https://github.com/apache/spark/commit/5a7b761ce2ffa5458d773cbe3cf77da778f6a6fa). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-132500988 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-132503483 [Test build #41231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41231/consoleFull) for PR 7874 at commit [`764a7ba`](https://github.com/apache/spark/commit/764a7ba319327b7f7e26140ad33213762acc99fc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7874#discussion_r37392589 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -118,9 +118,11 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli * Can be generated using [[org.apache.spark.scheduler.InputFormatInfo.computePreferredLocations]] * from a list of input files or InputFormats for the application. */ + @Deprecated(Passing in preferred locations has no effect at all, see SPARK-8949, 1.5.0) --- End diff -- Confirmed in https://issues.apache.org/jira/browse/SPARK-10099 @darkjh do you mind updating? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7874#discussion_r37281607 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -118,9 +118,11 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli * Can be generated using [[org.apache.spark.scheduler.InputFormatInfo.computePreferredLocations]] * from a list of input files or InputFormats for the application. */ + @Deprecated(Passing in preferred locations has no effect at all, see SPARK-8949, 1.5.0) --- End diff -- This is the `java.lang` annotation. Does it work with Scala? I thought we used `@deprecated` for this -- better for consistency even if both work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7874#discussion_r36947100 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -118,9 +118,11 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli * Can be generated using [[org.apache.spark.scheduler.InputFormatInfo.computePreferredLocations]] * from a list of input files or InputFormats for the application. */ + @Deprecated(Passing in preferred locations has no effect at all, see SPARK-8949) --- End diff -- this should be ```scala @deprecated((Passing in preferred locations has no effect at all, see SPARK-8949, 1.5.0) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-130860947 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-130860824 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-130860791 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user darkjh commented on a diff in the pull request: https://github.com/apache/spark/pull/7874#discussion_r37030653 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -118,9 +118,11 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli * Can be generated using [[org.apache.spark.scheduler.InputFormatInfo.computePreferredLocations]] * from a list of input files or InputFormats for the application. */ + @Deprecated(Passing in preferred locations has no effect at all, see SPARK-8949) --- End diff -- Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user darkjh commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-130083455 Should I rebase this to the master to solve the build fail? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-129720547 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-129718869 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-129718798 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-129718858 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-130090946 The tests are in an extraordinary flaky state now, so it's unlikely to be caused by your patch, especially since Jenkins tests merge commits. Let's just retest and see if the problem re-occurs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-130090954 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-130091321 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-130091349 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-130091668 [Test build #40527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40527/consoleFull) for PR 7874 at commit [`94021b8`](https://github.com/apache/spark/commit/94021b8ce4f042896dc4879837ad50a77bac04cc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-130093124 [Test build #40527 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40527/console) for PR 7874 at commit [`94021b8`](https://github.com/apache/spark/commit/94021b8ce4f042896dc4879837ad50a77bac04cc). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-130093129 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-127438873 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/7874#discussion_r36062508 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -113,6 +113,7 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli /** * :: DeveloperApi :: * Alternative constructor for setting preferred locations where Spark will create executors. + * Note that preferred locations feature does not work as it is supposed to, see SPARK-8949 --- End diff -- I would be more explicit and say that passing in preferred node location data has no effect at all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7874#discussion_r36062537
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -153,6 +155,8 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
preferredNodeLocationData: Map[String, Set[SplitInfo]] = Map()) =
{
this(SparkContext.updatedConf(new SparkConf(), master, appName,
sparkHome, jars, environment))
+if (preferredNodeLocationData.size 0)
--- End diff --
Use curly braces around if block
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user darkjh commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-127199849 @JoshRosen @sryza Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-127074699 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
GitHub user darkjh opened a pull request: https://github.com/apache/spark/pull/7874 SPARK-8949 - Print warnings when using preferred locations feature Add warnings according to SPARK-8949 in `SparkContext` - warnings in scaladoc - log warnings when preferred locations feature is used through `SparkContext`'s constructor However I didn't found any documentation reference of this feature. Please direct me if you know any reference to this feature. You can merge this pull request into a Git repository by running: $ git pull https://github.com/darkjh/spark SPARK-8949 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/7874.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7874 commit 329bfcb8f08c024b789b9c721471734ecc361173 Author: Han JU ju.han.fe...@gmail.com Date: 2015-08-02T23:29:52Z SPARK-8949 - Print warnings when using preferred locations feature --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7874#discussion_r36048691
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -121,6 +122,7 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
@DeveloperApi
def this(config: SparkConf, preferredNodeLocationData: Map[String,
Set[SplitInfo]]) = {
--- End diff --
We should probably mark this constructor as `@Deprecated` as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-8949 - Print warnings when using preferr...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7874#issuecomment-127074761 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
