[GitHub] spark pull request #13914: [SPARK-16111][SQL][DOC] Hide SparkOrcNewRecordRea...

2016-06-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13914


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #13914: [SPARK-16111][SQL][DOC] Hide SparkOrcNewRecordRea...

2016-06-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/13914#discussion_r68681583
  
--- Diff: project/SparkBuild.scala ---
@@ -720,6 +720,7 @@ object Unidoc {
 // Skip class names containing $ and some internal packages in Javadocs
 unidocAllSources in (JavaUnidoc, unidoc) := {
   ignoreUndocumentedPackages((unidocAllSources in (JavaUnidoc, 
unidoc)).value)
+
.map(_.filterNot(_.getCanonicalPath.contains("org/apache/hadoop/hive/ql/io/orc")))
--- End diff --

Thank you for review, @rxin . :) 
Sure. I'll update it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #13914: [SPARK-16111][SQL][DOC] Hide SparkOrcNewRecordRea...

2016-06-27 Thread rxin
Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13914#discussion_r68677923
  
--- Diff: project/SparkBuild.scala ---
@@ -720,6 +720,7 @@ object Unidoc {
 // Skip class names containing $ and some internal packages in Javadocs
 unidocAllSources in (JavaUnidoc, unidoc) := {
   ignoreUndocumentedPackages((unidocAllSources in (JavaUnidoc, 
unidoc)).value)
+
.map(_.filterNot(_.getCanonicalPath.contains("org/apache/hadoop/hive/ql/io/orc")))
--- End diff --

i'd exclude everything in org/apache/hadoop?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org