[GitHub] spark pull request #15654: [SPARK-16881][MESOS] Migrate Mesos configs to use...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/15654


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15654: [SPARK-16881][MESOS] Migrate Mesos configs to use...

[mgummelt]

Github user mgummelt commented on a diff in the pull request:

https://github.com/apache/spark/pull/15654#discussion_r85799941
  
--- Diff: 
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcher.scala 
---
@@ -51,7 +52,7 @@ private[mesos] class MesosClusterDispatcher(
   extends Logging {
 
   private val publicAddress = 
Option(conf.getenv("SPARK_PUBLIC_DNS")).getOrElse(args.host)
-  private val recoveryMode = conf.get("spark.deploy.recoveryMode", 
"NONE").toUpperCase()
+  private val recoveryMode = 
conf.get(RECOVERY_MODE).getOrElse("NONE").toUpperCase()
--- End diff --

Shouldn't the "NONE" default be added to the config builder?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15654: [SPARK-16881][MESOS] Migrate Mesos configs to use...

[techaddict]

GitHub user techaddict opened a pull request:

https://github.com/apache/spark/pull/15654

[SPARK-16881][MESOS] Migrate Mesos configs to use ConfigEntry

## What changes were proposed in this pull request?
Migrate Mesos configs to use ConfigEntry

## How was this patch tested?
Jenkins Tests

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/techaddict/spark SPARK-16881

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/15654.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15654


commit 55ff640abd8703826590bde7d0d4f7604272142e
Author: Sandeep Singh 
Date:   2016-10-27T02:59:16Z

[SPARK-16881] Migrate Mesos configs to use ConfigEntry

commit af306bd3c2d182d890fd769dffb190da2c2620ab
Author: Sandeep Singh 
Date:   2016-10-27T02:59:57Z

Merge branch 'master' into SPARK-16881




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org