[GitHub] spark pull request #15816: SPARK-18368: Fix regexp_replace with task seriali...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/15816


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15816: SPARK-18368: Fix regexp_replace with task seriali...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/15816#discussion_r87111002
  
--- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala
 ---
@@ -191,4 +192,17 @@ class RegexpExpressionsSuite extends SparkFunSuite 
with ExpressionEvalHelper {
 checkEvaluation(StringSplit(s1, s2), null, row3)
   }
 
+  test("RegExpReplace serialization") {
+val serializer = new JavaSerializer(new SparkConf()).newInstance
--- End diff --

Maybe we should add such a similar test to `ExpressionEvalHelper`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15816: SPARK-18368: Fix regexp_replace with task seriali...

[rdblue]

GitHub user rdblue opened a pull request:

https://github.com/apache/spark/pull/15816

SPARK-18368: Fix regexp_replace with task serialization.

## What changes were proposed in this pull request?

This makes the result value both transient and lazy, so that if the 
RegExpReplace object is initialized then serialized, `result: StringBuffer` 
will be correctly initialized.

## How was this patch tested?

Verified that this patch fixed the query that found the bug.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rdblue/spark SPARK-18368-fix-regexp-replace

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/15816.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15816


commit 8740a2c3b918796e1ac87c3e178f9f9f4651cb75
Author: Ryan Blue 
Date:   2016-10-26T16:42:43Z

SPARK-18368: Fix regexp_replace with task serialization.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org