GitHub user viirya opened a pull request:

    https://github.com/apache/spark/pull/15824

    [SQL] Skip subexpression elimination for conditional expressions

    ## What changes were proposed in this pull request?
    
    As per discussion at #15807, we should disallow subexpression elimination 
for expressions wrapped in conditional expressions such as `If`.
    
    ## How was this patch tested?
    
    Jenkins tests.
    
    Please review 
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark before 
opening a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/viirya/spark-1 
no-subexpr-eliminate-conditionexpr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15824.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15824
    
----
commit 548e45f63f64a3f9e9709af39610ce50390b0fa1
Author: Liang-Chi Hsieh <vii...@gmail.com>
Date:   2016-11-09T04:25:21Z

    Skip subexpression elimination for conditional expressions.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to