[GitHub] spark pull request #15843: [SPARK-18274][ML][PYSPARK] Memory leak in PySpark...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15843 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15843: [SPARK-18274][ML][PYSPARK] Memory leak in PySpark...
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15843#discussion_r87555658 --- Diff: python/pyspark/ml/wrapper.py --- @@ -180,6 +184,24 @@ def __get_class(clazz): % stage_name) return py_stage +def copy(self, extra=None): +""" +Creates a copy of this instance with the same uid and some +extra params. This implementation first calls Params.copy and +then make a copy of the companion Java model with extra params. --- End diff -- nit: Java model -> Java pipeline component. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15843: [SPARK-18274][ML][PYSPARK] Memory leak in PySpark...
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/15843#discussion_r87550799 --- Diff: python/pyspark/ml/wrapper.py --- @@ -33,6 +33,10 @@ def __init__(self, java_obj=None): super(JavaWrapper, self).__init__() self._java_obj = java_obj +def __del__(self): +if SparkContext._active_spark_context: --- End diff -- checking if there is active spark context, got this error after `quit()` in `pyspark` ``` Exception ignored in: Traceback (most recent call last): File "/Users/xx/Project/Spark/python/pyspark/ml/wrapper.py", line 37, in __del__ SparkContext._active_spark_context._gateway.detach(self._java_obj) AttributeError: 'NoneType' object has no attribute '_gateway' Exception ignored in: Traceback (most recent call last): File "/Users/xx/Project/Spark/python/pyspark/ml/wrapper.py", line 37, in __del__ AttributeError: 'NoneType' object has no attribute '_gateway' ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
