[GitHub] spark pull request #15934: [SPARK-18497][SS]Make ForeachSink support waterma...

2016-11-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/15934


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #15934: [SPARK-18497][SS]Make ForeachSink support waterma...

2016-11-18 Thread zsxwing
GitHub user zsxwing opened a pull request:

https://github.com/apache/spark/pull/15934

[SPARK-18497][SS]Make ForeachSink support watermark

## What changes were proposed in this pull request?

The issue in ForeachSink is the new created DataSet still uses the old 
QueryExecution. When `foreachPartition` is called, `QueryExecution.toString` 
will be called and then fail because it doesn't know how to plan 
EventTimeWatermark.

This PR just replaces the QueryExecution with IncrementalExecution to fix 
the issue.

## How was this patch tested?

`test("foreach with watermark")`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zsxwing/spark SPARK-18497

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/15934.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15934


commit 0f3e4af26054c4bf5877d671e9df5301ef48d3fd
Author: Shixiong Zhu 
Date:   2016-11-18T22:07:10Z

Make ForeachSink support watermark




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org