[GitHub] spark pull request #16099: [SPARK-18665][SQL] set statement state to "ERROR"...
Github user cenyuhai commented on a diff in the pull request:
https://github.com/apache/spark/pull/16099#discussion_r165878592
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
---
@@ -241,6 +241,8 @@ private[hive] class SparkExecuteStatementOperation(
dataTypes =
result.queryExecution.analyzed.output.map(_.dataType).toArray
} catch {
case e: HiveSQLException =>
+HiveThriftServer2.listener.onStatementError(
+ statementId, e.getMessage, SparkUtils.exceptionString(e))
--- End diff --
please catch the exception in ThriftServerPage.errorMessageCell. Without my
pr, that function still throw exception.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16099: [SPARK-18665][SQL] set statement state to "ERROR"...
Github user cenyuhai commented on a diff in the pull request:
https://github.com/apache/spark/pull/16099#discussion_r165877094
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
---
@@ -241,6 +241,8 @@ private[hive] class SparkExecuteStatementOperation(
dataTypes =
result.queryExecution.analyzed.output.map(_.dataType).toArray
} catch {
case e: HiveSQLException =>
+HiveThriftServer2.listener.onStatementError(
+ statementId, e.getMessage, SparkUtils.exceptionString(e))
--- End diff --
ok, but My pr is closed by community...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16099: [SPARK-18665][SQL] set statement state to "ERROR"...
Github user BruceXu1991 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16099#discussion_r165876866
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
---
@@ -241,6 +241,8 @@ private[hive] class SparkExecuteStatementOperation(
dataTypes =
result.queryExecution.analyzed.output.map(_.dataType).toArray
} catch {
case e: HiveSQLException =>
+HiveThriftServer2.listener.onStatementError(
+ statementId, e.getMessage, SparkUtils.exceptionString(e))
--- End diff --
This PR still occurs in Spark 2.2.1. A workaround is to use
"String.valueOf(e.getMessage)" instead of "e.getMessage" to avoid of NPE
problem.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16099: [SPARK-18665][SQL] set statement state to "ERROR"...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16099 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16099: [SPARK-18665][SQL] set statement state to "ERROR"...
Github user BruceXu1991 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16099#discussion_r116693874
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
---
@@ -241,6 +241,8 @@ private[hive] class SparkExecuteStatementOperation(
dataTypes =
result.queryExecution.analyzed.output.map(_.dataType).toArray
} catch {
case e: HiveSQLException =>
+HiveThriftServer2.listener.onStatementError(
+ statementId, e.getMessage, SparkUtils.exceptionString(e))
--- End diff --
I tried your code. there seems have a bug.
e.getMessage may get a null value, which may cause NPE in
ThriftServerPage.errorMessageCell(detail)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16099: [SPARK-18665][SQL] set statement state to error a...
GitHub user cenyuhai opened a pull request: https://github.com/apache/spark/pull/16099 [SPARK-18665][SQL] set statement state to error after user canceled job ## What changes were proposed in this pull request? set statement state to error after user canceled job You can merge this pull request into a Git repository by running: $ git pull https://github.com/cenyuhai/spark spark-18665 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/16099.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16099 commit e3a9b0896db7371252a66cc6b84bd7db921268c1 Author: cenyuhai <261810...@qq.com> Date: 2016-12-01T10:26:43Z set statement state to error after user canceled job --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
