[GitHub] spark pull request #16199: [SPARK-18772][SQL] NaN/Infinite float parsing in ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/16199


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16199: [SPARK-18772][SQL] NaN/Infinite float parsing in ...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/16199#discussion_r91450072
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
 ---
@@ -1764,4 +1764,37 @@ class JsonSuite extends QueryTest with 
SharedSQLContext with TestJsonData {
 val df2 = spark.read.option("PREfersdecimaL", "true").json(records)
 assert(df2.schema == schema)
   }
+
+  test("SPARK-18772: Special floats") {
+val records = sparkContext
--- End diff --

I think it would be nicer if it has some roundtrip tests in reading and 
writing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16199: [SPARK-18772][SQL] NaN/Infinite float parsing in ...

[NathanHowell]

GitHub user NathanHowell opened a pull request:

https://github.com/apache/spark/pull/16199

[SPARK-18772][SQL] NaN/Infinite float parsing in JSON is inconsistent

## What changes were proposed in this pull request?

This relaxes the parsing of `Float` and `Double` columns to properly 
support mixed case values of `NaN` and (+/-)`Infinity`, as well as properly 
supporting (+/-)`Inf`. Currently a string literal of `Nan` or `InfinitY` will 
cause a task to fail instead of placing the record in the corrupt record 
column, and `Inf` causes a failure instead of being a valid double.

## How was this patch tested?

Additional unit tests have been added

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NathanHowell/spark SPARK-18772

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/16199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16199


commit 11ac4438e12dc01ba252304da8793077280f3067
Author: Nathan Howell 
Date:   2016-12-07T23:32:14Z

[SPARK-18772][SQL] NaN/Infinite float parsing in JSON is inconsistent




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org