[GitHub] spark pull request #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

[jaceklaskowski]

Github user jaceklaskowski commented on a diff in the pull request:

https://github.com/apache/spark/pull/16309#discussion_r92784014
  
--- Diff: pom.xml ---
@@ -714,7 +714,7 @@
   
 org.scalacheck
 scalacheck_${scala.binary.version}
-1.12.5 
+1.13.4
--- End diff --

Yes, I did use maven for the entire local built and sbt for this particular 
`DAGSchedulerSuite` (that it all started from actually).

I've got little experience with Spark test suite and hence I'm relying on 
Jenkins to do the heavy-lifting and see how things may have changed since the 
comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/16309#discussion_r92782791
  
--- Diff: pom.xml ---
@@ -714,7 +714,7 @@
   
 org.scalacheck
 scalacheck_${scala.binary.version}
-1.12.5 
+1.13.4
--- End diff --

Yes, I remember this didn't work. Jenkins runs SBT; are you checking Maven 
locally? 
I'd like to update, sure, but want to make sure we don't trip over whatever 
I found before.

We could consider updating to scalatest 3.0.1 as well, in any event. As a 
test-only dependency it should be safe to more freely update it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/16309#discussion_r92777362
  
--- Diff: pom.xml ---
@@ -714,7 +714,7 @@
   
 org.scalacheck
 scalacheck_${scala.binary.version}
-1.12.5 
+1.13.4
--- End diff --

Hi @jaceklaskowski, I just wonder if it is safe assuming from the command 
beside, `1.13.0 appears incompatible with scalatest 2.2.6`. I just read 
`https://github.com/rickynils/scalacheck/issues/217` BTW.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

[jaceklaskowski]

GitHub user jaceklaskowski opened a pull request:

https://github.com/apache/spark/pull/16309

[SPARK-18896][TESTS] Suppress ScalaCheck warning

## What changes were proposed in this pull request?

Fixes ScalaCheck warning by upgrading to the latest 1.13.4 version.

```
Warning: Unknown ScalaCheck args provided: -oDF
```

The reason is due to a bug in ScalaCheck as reported in 
https://github.com/rickynils/scalacheck/issues/212 and fixed in 
https://github.com/rickynils/scalacheck/commit/df435a5 that is available in 
ScalaCheck 1.13.4.

Spark uses ScalaCheck 1.12.5 which is behind the latest 1.12.6 released on 
Nov 1 (not to mention 1.13.4).

## How was this patch tested?

Local build. Waiting for Jenkins.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaceklaskowski/spark SPARK-18896

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/16309.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16309


commit 9a18c106f342d39216920b495f94e9855e44fda7
Author: Jacek Laskowski 
Date:   2016-12-16T09:05:29Z

[SPARK-18896] Suppress ScalaCheck warning




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org