[GitHub] spark pull request #16738: [SPARK-19398] Change one misleading log in TaskSe...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16738: [SPARK-19398] Change one misleading log in TaskSe...
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16738#discussion_r99523053
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -799,7 +799,7 @@ private[spark] class TaskSetManager(
if (successful(index)) {
logInfo(
s"Task ${info.id} in stage ${taskSet.id} (TID $tid) failed, " +
-"but another instance of the task has already succeeded, " +
+"but it is already marked as successful, " +
--- End diff --
How about
"Task ${info.id} in stage ${taskSet.id} (TID $tid) failed, but the task
will not be re-executed (either because the task failed with a fetch failure,
so the previous stage needs to be re-run, or because a different copy of the
task has already succeeded)"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16738: [SPARK-19398] Change one misleading log in TaskSe...
GitHub user jinxing64 reopened a pull request:
https://github.com/apache/spark/pull/16738
[SPARK-19398] Change one misleading log in TaskSetManager.
## What changes were proposed in this pull request?
Log below is misleading:
```
if (successful(index)) {
logInfo(
s"Task ${info.id} in stage ${taskSet.id} (TID $tid) failed, " +
"but another instance of the task has already succeeded, " +
"so not re-queuing the task to be re-executed.")
}
```
If fetch failed, the task is marked as successful in `TaskSetManager::
handleFailedTask`. Then log above will be printed. The `successful` just means
task will not be scheduled any longer, not a real success.
## How was this patch tested?
Existing unit tests can cover this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinxing64/spark SPARK-19398
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16738.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16738
commit 6ccd9f5cb6c03bad6a7a01104a95c277218ffa2d
Author: jinxing
Date: 2017-02-05T03:46:35Z
[SPARK-19398] Change one misleading log in TaskSetManager.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16738: [SPARK-19398] Change one misleading log in TaskSe...
Github user jinxing64 closed the pull request at: https://github.com/apache/spark/pull/16738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
