[GitHub] spark pull request #17081: [SPARK-18726][SQL]resolveRelation for FileFormat ...

2017-03-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/17081


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #17081: [SPARK-18726][SQL]resolveRelation for FileFormat ...

2017-03-02 Thread windpiger
Github user windpiger commented on a diff in the pull request:

https://github.com/apache/spark/pull/17081#discussion_r104075579
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ---
@@ -106,6 +106,7 @@ case class DataSource(
* be any further inference in any triggers.
*
* @param format the file format object for this DataSource
+   * @param fileStatusCache fileStatusCache for InMemoryFileIndex
--- End diff --

ok thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #17081: [SPARK-18726][SQL]resolveRelation for FileFormat ...

2017-03-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/17081#discussion_r104073970
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ---
@@ -106,6 +106,7 @@ case class DataSource(
* be any further inference in any triggers.
*
* @param format the file format object for this DataSource
+   * @param fileStatusCache fileStatusCache for InMemoryFileIndex
--- End diff --

`@param fileStatusCache the shared cache for file statuses to speed up 
listing`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #17081: [SPARK-18726][SQL]resolveRelation for FileFormat ...

2017-03-02 Thread windpiger
Github user windpiger commented on a diff in the pull request:

https://github.com/apache/spark/pull/17081#discussion_r104065615
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ---
@@ -109,7 +109,9 @@ case class DataSource(
* @return A pair of the data schema (excluding partition columns) and 
the schema of the partition
* columns.
*/
-  private def getOrInferFileFormatSchema(format: FileFormat): (StructType, 
StructType) = {
+  private def getOrInferFileFormatSchema(
+  format: FileFormat,
+  fileStatusCache: FileStatusCache = NoopCache): (StructType, 
StructType) = {
--- End diff --

ok, thanks~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org