[GitHub] spark pull request #17277: [SPARK-19887][SQL] dynamic partition keys can be ...

2017-03-14 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/17277


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #17277: [SPARK-19887][SQL] dynamic partition keys can be ...

2017-03-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/17277#discussion_r106010139
  
--- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala
 ---
@@ -316,6 +316,28 @@ class PartitionProviderCompatibilitySuite
 }
   }
 }
+
+test(s"SPARK-19887 partition value is null - partition management 
$enabled") {
--- End diff --

Nit: `is null` -> `is null or empty`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org