[GitHub] spark pull request #17511: [SPARK-20195][SPARKR][SQL] add createTable catalo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/17511


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17511: [SPARK-20195][SPARKR][SQL] add createTable catalo...

[felixcheung]

Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/17511#discussion_r109833091
  
--- Diff: R/pkg/R/DataFrame.R ---
@@ -557,7 +557,7 @@ setMethod("insertInto",
 jmode <- convertToJSaveMode(ifelse(overwrite, "overwrite", 
"append"))
 write <- callJMethod(x@sdf, "write")
 write <- callJMethod(write, "mode", jmode)
-callJMethod(write, "insertInto", tableName)
+invisible(callJMethod(write, "insertInto", tableName))
--- End diff --

It's a R usability thing: for method not returning any value (in these 
cases the Scala method is defined as `foo : Unit`), it will print NULL.

so we say `invisible` to get it to not print out the value, that's all


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17511: [SPARK-20195][SPARKR][SQL] add createTable catalo...

[gatorsmile]

Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/17511#discussion_r109816897
  
--- Diff: R/pkg/R/DataFrame.R ---
@@ -557,7 +557,7 @@ setMethod("insertInto",
 jmode <- convertToJSaveMode(ifelse(overwrite, "overwrite", 
"append"))
 write <- callJMethod(x@sdf, "write")
 write <- callJMethod(write, "mode", jmode)
-callJMethod(write, "insertInto", tableName)
+invisible(callJMethod(write, "insertInto", tableName))
--- End diff --

Just wondering what is the reason why we add `invisible` in this PR? Is it 
related to this deprecation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17511: [SPARK-20195][SPARKR][SQL] add createTable catalo...

[felixcheung]

GitHub user felixcheung opened a pull request:

https://github.com/apache/spark/pull/17511

[SPARK-20195][SPARKR][SQL] add createTable catalog API and deprecate 
createExternalTable

## What changes were proposed in this pull request?

Following up on #17483, add createTable (which is new in 2.2.0) and 
deprecate createExternalTable, plus a number of minor fixes

## How was this patch tested?

manual, unit tests

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/felixcheung/spark rceatetable

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/17511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17511


commit b424a52b90c436b2400013a3dc69f351c9e7bdf9
Author: Felix Cheung 
Date:   2017-04-02T19:03:25Z

add createTable, deprecate createExternalTable, fix invisible on API 
without return values




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org