[GitHub] spark pull request #17894: [WIP][SPARK-17134][ML] Use level 2 BLAS operation...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17894 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #17894: [WIP][SPARK-17134][ML] Use level 2 BLAS operation...
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17894#discussion_r132249512
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1722,25 +1723,22 @@ private class LogisticAggregator(
var maxMargin = Double.NegativeInfinity
val margins = new Array[Double](numClasses)
+val featureStdArray = new Array[Double](features.size)
features.foreachActive { (index, value) =>
- val stdValue = value / localFeaturesStd(index)
- var j = 0
- while (j < numClasses) {
-margins(j) += localCoefficients(index * numClasses + j) * stdValue
-j += 1
- }
+ featureStdArray(index) = value / localFeaturesStd(index)
--- End diff --
it seems to be a bug, I send a PR to fix this #18896
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #17894: [WIP][SPARK-17134][ML] Use level 2 BLAS operation...
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17894#discussion_r132068663 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1722,25 +1723,22 @@ private class LogisticAggregator( var maxMargin = Double.NegativeInfinity val margins = new Array[Double](numClasses) +val featureStdArray = new Array[Double](features.size) --- End diff -- I suggest change the `featureStdArray` as Aggregator class member, so that avoid each update allocate a new temporary array. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #17894: [WIP][SPARK-17134][ML] Use level 2 BLAS operation...
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17894#discussion_r132069046
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1722,25 +1723,22 @@ private class LogisticAggregator(
var maxMargin = Double.NegativeInfinity
val margins = new Array[Double](numClasses)
+val featureStdArray = new Array[Double](features.size)
features.foreachActive { (index, value) =>
- val stdValue = value / localFeaturesStd(index)
- var j = 0
- while (j < numClasses) {
-margins(j) += localCoefficients(index * numClasses + j) * stdValue
-j += 1
- }
+ featureStdArray(index) = value / localFeaturesStd(index)
--- End diff --
Here why don't handle the case `localFeaturesStd(index) == 0.0` ?
I remember other place it handle such case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
