[GitHub] spark pull request #18321: [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18321


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18321: [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s...

[jerryshao]

Github user jerryshao commented on a diff in the pull request:

https://github.com/apache/spark/pull/18321#discussion_r122365295
  
--- Diff: 
core/src/test/scala/org/apache/spark/deploy/master/MasterSuite.scala ---
@@ -214,7 +214,7 @@ class MasterSuite extends SparkFunSuite
   master.rpcEnv.setupEndpoint(Master.ENDPOINT_NAME, master)
   // Wait until Master recover from checkpoint data.
   eventually(timeout(5 seconds), interval(100 milliseconds)) {
-master.idToApp.size should be(1)
+master.workers.size should be(1)
--- End diff --

yes, that's right.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18321: [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s...

[jiangxb1987]

Github user jiangxb1987 commented on a diff in the pull request:

https://github.com/apache/spark/pull/18321#discussion_r122359325
  
--- Diff: 
core/src/test/scala/org/apache/spark/deploy/master/MasterSuite.scala ---
@@ -214,7 +214,7 @@ class MasterSuite extends SparkFunSuite
   master.rpcEnv.setupEndpoint(Master.ENDPOINT_NAME, master)
   // Wait until Master recover from checkpoint data.
   eventually(timeout(5 seconds), interval(100 milliseconds)) {
-master.idToApp.size should be(1)
+master.workers.size should be(1)
--- End diff --

I think the reason is workers are recovered later than applications.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18321: [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s...

[cloud-fan]

Github user cloud-fan commented on a diff in the pull request:

https://github.com/apache/spark/pull/18321#discussion_r122359276
  
--- Diff: 
core/src/test/scala/org/apache/spark/deploy/master/MasterSuite.scala ---
@@ -214,7 +214,7 @@ class MasterSuite extends SparkFunSuite
   master.rpcEnv.setupEndpoint(Master.ENDPOINT_NAME, master)
   // Wait until Master recover from checkpoint data.
   eventually(timeout(5 seconds), interval(100 milliseconds)) {
-master.idToApp.size should be(1)
+master.workers.size should be(1)
--- End diff --

can you explain more about why it may fail?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18321: [SPARK-12552][FOLLOWUP] Fix flaky test for "o.a.s...

[jerryshao]

GitHub user jerryshao opened a pull request:

https://github.com/apache/spark/pull/18321

[SPARK-12552][FOLLOWUP] Fix flaky test for 
"o.a.s.deploy.master.MasterSuite.master correctly recover the application"

## What changes were proposed in this pull request?

Due to the RPC asynchronous event processing, The test "correctly recover 
the application" could potentially be failed. The issue could be found in here: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78126/testReport/org.apache.spark.deploy.master/MasterSuite/master_correctly_recover_the_application/.

So here fixing this flaky test.

## How was this patch tested?

Existing UT.

CC @cloud-fan @jiangxb1987 , please help to review, thanks!


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jerryshao/apache-spark SPARK-12552-followup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18321


commit 55c5d12023dec1cbf2e8aa6b4507c49c3df5b322
Author: jerryshao 
Date:   2017-06-16T03:10:48Z

Fix flaky test

Change-Id: I20f1a68b682cbfda05be319b365495c80fb4cda4




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org