[GitHub] spark pull request #18328: [SPARK-21121][SQL] Support changing storage level...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18328


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18328: [SPARK-21121][SQL] Support changing storage level...

[dosoft]

Github user dosoft commented on a diff in the pull request:

https://github.com/apache/spark/pull/18328#discussion_r129031454
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -106,6 +105,11 @@ class CacheManager extends Logging {
 }
   }
 
+  def cacheQuery(query: Dataset[_], tableName: Option[String] = None): 
Unit = writeLock {
+cacheQuery(query, tableName, StorageLevel.fromString(
+  query.sparkSession.sessionState.conf.cacheStorageLevel))
--- End diff --

Could you explain your question in a bit more details?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18328: [SPARK-21121][SQL] Support changing storage level...

[felixcheung]

Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/18328#discussion_r122872220
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -106,6 +105,11 @@ class CacheManager extends Logging {
 }
   }
 
+  def cacheQuery(query: Dataset[_], tableName: Option[String] = None): 
Unit = writeLock {
+cacheQuery(query, tableName, StorageLevel.fromString(
+  query.sparkSession.sessionState.conf.cacheStorageLevel))
--- End diff --

btw, this is a bit odd to roundtrip to string <-> storagelevel


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18328: [SPARK-21121][SQL] Support changing storage level...

[gatorsmile]

Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/18328#discussion_r122485448
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -106,6 +106,13 @@ class CacheManager extends Logging {
 }
   }
 
+  def cacheQuery(
+query: Dataset[_],
+tableName: Option[String] = None
+  ): Unit = writeLock {
--- End diff --

Combine the two lines together


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18328: [SPARK-21121][SQL] Support changing storage level...

[gatorsmile]

Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/18328#discussion_r122485403
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -106,6 +106,13 @@ class CacheManager extends Logging {
 }
   }
 
+  def cacheQuery(
+query: Dataset[_],
+tableName: Option[String] = None
+  ): Unit = writeLock {
+cacheQuery(query, tableName, 
StorageLevel.fromString(query.sparkSession.sessionState.conf.cacheStorageLevel))
--- End diff --

This line exceeds 100 characters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18328: [SPARK-21121][SQL] Support changing storage level...

[dosoft]

GitHub user dosoft opened a pull request:

https://github.com/apache/spark/pull/18328

[SPARK-21121][SQL] Support changing storage level via the 
spark.sql.inMemoryColumnarStorage.level variable

## What changes were proposed in this pull request?

As described in title

## How was this patch tested?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dosoft/spark SPARK-21121

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18328


commit f6dfaabb1f62005500b496f79bcb57e2a3b0d15e
Author: Oleg Danilov 
Date:   2017-06-15T08:01:16Z

[SPARK-21121][SQL] Support changing storage level via the 
spark.sql.inMemoryColumnarStorage.level variable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org