[GitHub] spark pull request #18493: [SPARK-20889][SparkR][Followup] Clean up grouped ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18493


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18493: [SPARK-20889][SparkR][Followup] Clean up grouped ...

[felixcheung]

Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/18493#discussion_r125523031
  
--- Diff: R/pkg/R/functions.R ---
@@ -38,9 +38,9 @@ NULL
 #'
 #' Date time functions defined for \code{Column}.
 #'
-#' @param x Column to compute on.
-#' @param format For \code{to_date} and \code{to_timestamp}, it is the 
string to use to parse
-#'   x Column to DateType or TimestampType. For \code{trunc}, 
it is the string used
+#' @param x Column to compute on. In \code{window}, it must be a time 
Column of \code{TimestampType}.
+#' @param format For \code{to_date} and \code{to_timestamp}, it is the 
string used to parse
--- End diff --

ah I guess it isn't consistent with `trunc` below


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18493: [SPARK-20889][SparkR][Followup] Clean up grouped ...

[felixcheung]

Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/18493#discussion_r125522977
  
--- Diff: R/pkg/R/functions.R ---
@@ -38,9 +38,9 @@ NULL
 #'
 #' Date time functions defined for \code{Column}.
 #'
-#' @param x Column to compute on.
-#' @param format For \code{to_date} and \code{to_timestamp}, it is the 
string to use to parse
-#'   x Column to DateType or TimestampType. For \code{trunc}, 
it is the string used
+#' @param x Column to compute on. In \code{window}, it must be a time 
Column of \code{TimestampType}.
+#' @param format For \code{to_date} and \code{to_timestamp}, it is the 
string used to parse
--- End diff --

`to use` seems to make sense though?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18493: [SPARK-20889][SparkR][Followup] Clean up grouped ...

[actuaryzhang]

GitHub user actuaryzhang opened a pull request:

https://github.com/apache/spark/pull/18493

[SPARK-20889][SparkR][Followup] Clean up grouped doc for column methods 

## What changes were proposed in this pull request?
Add doc for methods that were left out, and fix various style and 
consistency issues. 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/actuaryzhang/spark sparkRDocCleanup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18493.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18493


commit 700e73c16fdfca4cc66605b28c6521d8d55f82de
Author: actuaryzhang 
Date:   2017-06-30T07:05:13Z

add doc for spark_partition_id

commit c97caa91f9b264b8393850ac2c75440602d457b5
Author: actuaryzhang 
Date:   2017-06-30T07:16:20Z

add doc for window

commit 2ea1d0ab8c60a59f6b235ac771fa5a72dc48f9fe
Author: actuaryzhang 
Date:   2017-06-30T07:24:58Z

fix issue in example

commit 1e45874517a773e3de7c718a3b74f95682b2f0cb
Author: actuaryzhang 
Date:   2017-06-30T20:49:20Z

fix style




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org