[GitHub] spark pull request #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation ...

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18702


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation ...

2017-07-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/18702#discussion_r129254786
  
--- Diff: docs/_plugins/copy_api_dirs.rb ---
@@ -150,4 +150,31 @@
 cp("../R/pkg/DESCRIPTION", "api")
   end
 
+  if not (ENV['SKIP_SQLDOC'] == '1')
+# Build SQL API docs
+
+puts "Moving to project root and building API docs."
+curr_dir = pwd
+cd("..")
--- End diff --

I think I misunderstood your previous comments initially. It shouldn't be 
hard.

but other language API docs are, up to my knowledge, in separate 
directories and then copied into `docs/` later. I was thinking we could extend 
this further in the future (e.g., syntax documentation) and it could be easier 
to check doc output in a separate dir (actually, for me, I check other docs 
output in this way more often).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation ...

2017-07-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/18702#discussion_r129251387
  
--- Diff: sql/gen-sql-markdown.py ---
@@ -0,0 +1,96 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import sys
--- End diff --

It should be pretty simple. Let me try.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation ...

2017-07-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/18702#discussion_r129251081
  
--- Diff: sql/log4j.properties ---
@@ -0,0 +1,24 @@
+#
--- End diff --

Oh, actually, I think I can get rid of this. Let me try.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation ...

2017-07-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/18702#discussion_r129250088
  
--- Diff: sql/log4j.properties ---
@@ -0,0 +1,24 @@
+#
--- End diff --

This is used - 
https://github.com/apache/spark/pull/18702/files#diff-a4b1e8e0e72fd59bd246285a34b21a45R49

I hesitated to add this one but just added to make the infos quiet when a 
spark session is initialised.

There is a similar one in R - 
https://github.com/apache/spark/blob/master/R/run-tests.sh#L26 and 
https://github.com/apache/spark/blob/master/R/log4j.properties but this case 
logs are quite small though.

```bash
$ sh create-docs.sh
```

**Before**

```
Generating markdown files for SQL documentation.
Generating HTML files for SQL documentation.
INFO-  Cleaning site directory
INFO-  Building documentation to directory: /.../spark/sql/site
```

**After**

```
Generating markdown files for SQL documentation.
Using Spark's default log4j profile: 
org/apache/spark/log4j-defaults.properties
17/07/25 18:02:57 INFO SparkContext: Running Spark version 2.3.0-SNAPSHOT
17/07/25 18:02:57 WARN NativeCodeLoader: Unable to load native-hadoop 
library for your platform... using builtin-java classes where applicable
17/07/25 18:02:57 INFO SparkContext: Submitted application: GenSQLDocs
17/07/25 18:02:57 INFO SecurityManager: Changing view acls to: hyukjinkwon
17/07/25 18:02:57 INFO SecurityManager: Changing modify acls to: hyukjinkwon
17/07/25 18:02:57 INFO SecurityManager: Changing view acls groups to:
17/07/25 18:02:57 INFO SecurityManager: Changing modify acls groups to:
17/07/25 18:02:57 INFO SecurityManager: SecurityManager: authentication 
disabled; ui acls disabled; users  with view permissions: Set(hyukjinkwon); 
groups with view permissions: Set(); users  with modify permissions: 
Set(hyukjinkwon); groups with modify permissions: Set()
17/07/25 18:02:58 INFO Utils: Successfully started service 'sparkDriver' on 
port 62695.
17/07/25 18:02:58 INFO SparkEnv: Registering MapOutputTracker
17/07/25 18:02:58 INFO SparkEnv: Registering BlockManagerMaster
17/07/25 18:02:58 INFO BlockManagerMasterEndpoint: Using 
org.apache.spark.storage.DefaultTopologyMapper for getting topology information
17/07/25 18:02:58 INFO BlockManagerMasterEndpoint: 
BlockManagerMasterEndpoint up
17/07/25 18:02:58 INFO DiskBlockManager: Created local directory at 
/private/var/folders/9j/gf_c342d7d150mwrxvkqnc18gn/T/blockmgr-13909519-0864-4aa3-82fb-eba4b9d1e527
17/07/25 18:02:58 INFO MemoryStore: MemoryStore started with capacity 366.3 
MB
17/07/25 18:02:58 INFO SparkEnv: Registering OutputCommitCoordinator
17/07/25 18:02:58 INFO Utils: Successfully started service 'SparkUI' on 
port 4040.
17/07/25 18:02:58 INFO SparkUI: Bound SparkUI to 0.0.0.0, and started at 
http://192.168.0.146:4040
17/07/25 18:02:58 INFO SparkContext: Added file 
file:/.../spark/sql/gen-sql-markdown.py at 
file:/.../spark/sql/gen-sql-markdown.py with timestamp 1500973378636
17/07/25 18:02:58 INFO Utils: Copying /.../spark/sql/gen-sql-markdown.py to 
/private/var/folders/9j/gf_c342d7d150mwrxvkqnc18gn/T/spark-0eb99795-6a5e-4101-8ed2-c55b3ba80173/userFiles-64210993-0ed8-4c05-85bd-83d13ae22831/gen-sql-markdown.py
17/07/25 18:02:58 INFO Executor: Starting executor ID driver on host 
localhost
17/07/25 18:02:58 INFO Utils: Successfully started service 
'org.apache.spark.network.netty.NettyBlockTransferService' on port 62696.
17/07/25 18:02:58 INFO NettyBlockTransferService: Server created on 
192.168.0.146:62696
17/07/25 18:02:58 INFO BlockManager: Using 
org.apache.spark.storage.RandomBlockReplicationPolicy for block replication 
policy
17/07/25 18:02:58 INFO BlockManagerMaster: Registering BlockManager 
BlockManagerId(driver, 192.168.0.146, 62696, None)
17/07/25 18:02:58 INFO BlockManagerMasterEndpoint: Registering block 
manager 192.168.0.146:62696 with 366.3 MB RAM, BlockManagerId(driver, 
192.168.0.146, 62696, None)
17/07/25 18:02:58 INFO BlockManagerMaster: Registered BlockManager 
BlockManagerId(driver, 192.168.0.146, 62696, None)
17/07/25 18:02:58 INFO BlockManager: Initialized BlockManager: 
BlockManagerId(driver, 192.168.0.146, 62696, None)
17/07/25 18:02:59 INFO SharedState: Setting hive.metastore.warehouse.dir 
('null') to the value of spark.sql.warehouse.dir 
('/.../spark/sql/_spark-warehouse').
17/07/25 18:02:59 INFO SharedState: Warehouse path is 
'/.../spark/sql/_spark-warehouse'.
17/07/25 18:02:59 INFO StateStoreCoordinatorRef: Registered 
StateStoreCoordinator endpoint
17/07/25 18:02:59 INFO SparkUI: Stopped Spark web UI at 
http://192.168.0.146:4040
17/07/25 18:02:59 INFO MapOutputTrackerMasterEndpoint: 
MapOutputTrackerMasterEndpoint stopped!
17/07/25 18:02:59 INFO MemoryStore: 

[GitHub] spark pull request #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation ...

2017-07-25 Thread srowen
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/18702#discussion_r129245196
  
--- Diff: docs/_plugins/copy_api_dirs.rb ---
@@ -150,4 +150,31 @@
 cp("../R/pkg/DESCRIPTION", "api")
   end
 
+  if not (ENV['SKIP_SQLDOC'] == '1')
+# Build SQL API docs
+
+puts "Moving to project root and building API docs."
+curr_dir = pwd
+cd("..")
--- End diff --

Rather than `cd`, is it possible to generate the output directly into 
`docs/` somewhere? maybe I miss why that's hard. It would avoid creating more 
temp output dirs in the `sql` folder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation ...

2017-07-25 Thread srowen
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/18702#discussion_r129245068
  
--- Diff: sql/gen-sql-markdown.py ---
@@ -0,0 +1,96 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import sys
--- End diff --

Does it complicate things to put these files in some kind of `bin` 
directory under `sql`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #18702: [SPARK-21485][SQL][DOCS] Spark SQL documentation ...

2017-07-25 Thread srowen
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/18702#discussion_r129244802
  
--- Diff: sql/log4j.properties ---
@@ -0,0 +1,24 @@
+#
--- End diff --

Pardon, is a log4j.properties really needed here? what reads it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org