[GitHub] spark pull request #18708: [SPARK-21339] [CORE] spark-shell --packages optio...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18708


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18708: [SPARK-21339] [CORE] spark-shell --packages optio...

[devaraj-kavali]

GitHub user devaraj-kavali opened a pull request:

https://github.com/apache/spark/pull/18708

[SPARK-21339] [CORE] spark-shell --packages option does not add jars to 
classpath on windows

## What changes were proposed in this pull request?
The --packages option jars are getting added to the classpath with the 
scheme as "file:///", in Unix it doesn't have problem with this since the 
scheme contains the Unix Path separator which separates the jar name with 
location in the classpath. In Windows, the jar file is not getting resolved 
from the classpath because of the scheme.

Windows : file:///C:/Users//.ivy2/jars/.jar
Unix : file:///home//.ivy2/jars/.jar

With this PR, we are avoiding the 'file://' scheme to get added to the 
packages jar files.

## How was this patch tested?
I have verified manually in Windows and Unix environments, with the change 
it adds the jar to classpath like below,

Windows : C:\Users\\.ivy2\jars\.jar
Unix : /home//.ivy2/jars/.jar


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/devaraj-kavali/spark SPARK-21339

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18708


commit 3242532d4815fa9595dd9ca2d4d0b86c6d206ddb
Author: Devaraj K 
Date:   2017-07-21T21:51:46Z

[SPARK-21339] [CORE] spark-shell --packages option does not add jars to
classpath on windows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org