[GitHub] spark pull request #18836: Update SortMergeJoinExec.scala
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18836 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18836: Update SortMergeJoinExec.scala
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18836#discussion_r131596479
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -82,7 +82,7 @@ case class SortMergeJoinExec(
override def outputOrdering: Seq[SortOrder] = joinType match {
// For inner join, orders of both sides keys should be kept.
-case Inner =>
+case _: InnerLike =>
--- End diff --
Yeah that makes sense
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18836: Update SortMergeJoinExec.scala
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18836#discussion_r131557287
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -82,7 +82,7 @@ case class SortMergeJoinExec(
override def outputOrdering: Seq[SortOrder] = joinType match {
// For inner join, orders of both sides keys should be kept.
-case Inner =>
+case _: InnerLike =>
--- End diff --
Even worse, this could cause an exception
```Scala
val df = Seq((1, 1)).toDF("i", "j")
df.createOrReplaceTempView("T")
withSQLConf(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") {
sql("select * from (select a.i from T a cross join T t where t.i = a.i)
as t1 " +
"cross join T t2 where t2.i = t1.i").explain(true)
}
```
It will return the following error:
```
SortMergeJoinExec should not take Cross as the JoinType
java.lang.IllegalArgumentException: SortMergeJoinExec should not take Cross
as the JoinType
at
org.apache.spark.sql.execution.joins.SortMergeJoinExec.outputOrdering(SortMergeJoinExec.scala:100)
at org.apache.spark.sql.execution.ProjectExec
```
We need to backport it to 2.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18836: Update SortMergeJoinExec.scala
Github user BoleynSu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18836#discussion_r131316095
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -82,7 +82,7 @@ case class SortMergeJoinExec(
override def outputOrdering: Seq[SortOrder] = joinType match {
// For inner join, orders of both sides keys should be kept.
-case Inner =>
+case _: InnerLike =>
--- End diff --
I think we can get a SortMergeJoin paln with Cross, e.g. `select distinct
a.i + 1,a.* from T a cross join T t where a.i > 1 and t.i = a.i group by a.i
having a.i > 2`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18836: Update SortMergeJoinExec.scala
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18836#discussion_r131239029
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -82,7 +82,7 @@ case class SortMergeJoinExec(
override def outputOrdering: Seq[SortOrder] = joinType match {
// For inner join, orders of both sides keys should be kept.
-case Inner =>
+case _: InnerLike =>
--- End diff --
Can someone explain to me what is being fixed here? The other `InnerLike`
variant, `Cross`, does not get planned using a `SortMergeJoin`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18836: Update SortMergeJoinExec.scala
GitHub user BoleynSu opened a pull request: https://github.com/apache/spark/pull/18836 Update SortMergeJoinExec.scala fix a bug in outputOrdering ## What changes were proposed in this pull request? Change `case Inner` to `case _: InnerLike` so that Cross will be handled properly. ## How was this patch tested? No unit tests are needed. Please review http://spark.apache.org/contributing.html before opening a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/BoleynSu/spark patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/18836.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18836 commit 54ba6bedb36e57698404dbaccb7d5639bf64770c Author: Boleyn Su Date: 2017-08-03T17:55:26Z Update SortMergeJoinExec.scala fix a bug in outputOrdering --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
