[GitHub] spark pull request #19276: [SPARK-22049][DOCS] Confusing behavior of from_ut...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/19276


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19276: [SPARK-22049][DOCS] Confusing behavior of from_ut...

[felixcheung]

Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/19276#discussion_r139868265
  
--- Diff: R/pkg/R/functions.R ---
@@ -2286,8 +2286,8 @@ setMethod("next_day", signature(y = "Column", x = 
"character"),
   })
 
 #' @details
-#' \code{to_utc_timestamp}: Given a timestamp, which corresponds to a 
certain time of day
-#' in the given timezone, returns another timestamp that corresponds to 
the same time of day in UTC.
+#' \code{to_utc_timestamp}: Given a timestamp like '2017-07-14 
02:40:00.0', interprets it as a time in the given
+# time zone, and renders that time as a timestamp in UTC. For example, 
'GMT+1' would yield '2017-07-14 01:40:00.0'.
--- End diff --

same here with `#` -> `#'`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19276: [SPARK-22049][DOCS] Confusing behavior of from_ut...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/19276#discussion_r139745184
  
--- Diff: R/pkg/R/functions.R ---
@@ -2226,8 +2226,8 @@ setMethod("from_json", signature(x = "Column", schema 
= "characterOrstructType")
   })
 
 #' @details
-#' \code{from_utc_timestamp}: Given a timestamp, which corresponds to a 
certain time of day in UTC,
-#' returns another timestamp that corresponds to the same time of day in 
the given timezone.
+#' \code{from_utc_timestamp}: Given a timestamp like '2017-07-14 
02:40:00.0', interprets it as a time in UTC, and
+# renders that time as a timestamp in the given time zone. For example, 
'GMT+1' would yield '2017-07-14 03:40:00.0'.
--- End diff --

Oh, and missing `#'` at the beginning.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19276: [SPARK-22049][DOCS] Confusing behavior of from_ut...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/19276#discussion_r139661924
  
--- Diff: R/pkg/R/functions.R ---
@@ -2226,8 +2226,8 @@ setMethod("from_json", signature(x = "Column", schema 
= "characterOrstructType")
   })
 
 #' @details
-#' \code{from_utc_timestamp}: Given a timestamp, which corresponds to a 
certain time of day in UTC,
-#' returns another timestamp that corresponds to the same time of day in 
the given timezone.
+#' \code{from_utc_timestamp}: Given a timestamp like '2017-07-14 
02:40:00.0', interprets it as a time in UTC, and
--- End diff --

I think lintr does not recognise this case but I believe these lines should 
fit in 100 character lengths ..


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19276: [SPARK-22049][DOCS] Confusing behavior of from_ut...

[srowen]

GitHub user srowen opened a pull request:

https://github.com/apache/spark/pull/19276

[SPARK-22049][DOCS] Confusing behavior of from_utc_timestamp and 
to_utc_timestamp

## What changes were proposed in this pull request?

Clarify behavior of to_utc_timestamp/from_utc_timestamp with an example

## How was this patch tested?

Doc only change / existing tests

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srowen/spark SPARK-22049

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/19276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19276


commit 3ff334ad5e6f94d1a667ea2bb070ea79cf240718
Author: Sean Owen 
Date:   2017-09-19T10:23:55Z

Clarify behavior of to_utc_timestamp/from_utc_timestamp with an example




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org