[GitHub] spark pull request #19754: [BUILD] update release scripts
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19754 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19754: [BUILD] update release scripts
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19754#discussion_r153052719 --- Diff: dev/create-release/release-build.sh --- @@ -392,6 +375,7 @@ if [[ "$1" == "publish-release" ]]; then find . -type f |grep -v \.jar |grep -v \.pom | xargs rm echo "Creating hash and signature files" + # this must have .asc, .md5 and .sha1 - it really doesn't like anything else there --- End diff -- it rejects it when there are "extra files" of the sha512 extension. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19754: [BUILD] update release scripts
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19754#discussion_r151158121
--- Diff: dev/create-release/release-build.sh ---
@@ -135,50 +143,24 @@ if [ -z "$SPARK_PACKAGE_VERSION" ]; then
SPARK_PACKAGE_VERSION="${SPARK_VERSION}-$(date
+%Y_%m_%d_%H_%M)-${git_hash}"
fi
-DEST_DIR_NAME="spark-$SPARK_PACKAGE_VERSION"
-
-function LFTP {
- SSH="ssh -o ConnectTimeout=300 -o StrictHostKeyChecking=no -i
$ASF_RSA_KEY"
- COMMANDS=$(cat \
spark-$SPARK_VERSION.tgz.md5
echo $GPG_PASSPHRASE | $GPG --passphrase-fd 0 --print-md \
-SHA512 spark-$SPARK_VERSION.tgz > spark-$SPARK_VERSION.tgz.sha
+SHA512 spark-$SPARK_VERSION.tgz > spark-$SPARK_VERSION.tgz.sha512
--- End diff --
+1 for making it explicit as sha will often default to SHA1
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19754: [BUILD] update release scripts
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19754#discussion_r151158312 --- Diff: dev/create-release/release-build.sh --- @@ -392,6 +375,7 @@ if [[ "$1" == "publish-release" ]]; then find . -type f |grep -v \.jar |grep -v \.pom | xargs rm echo "Creating hash and signature files" + # this must have .asc, .md5 and .sha1 - it really doesn't like anything else there --- End diff -- sha1, not sha512? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19754: [BUILD] update release scripts
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/19754 [BUILD] update release scripts ## What changes were proposed in this pull request? Change to dist.apache.org instead of home directory sha512 should have .sha512 extension. From ASF release signing doc: "The checksum SHOULD be generated using SHA-512. A .sha file SHOULD contain a SHA-1 checksum, for historical reasons." NOTE: I *think* should require some changes to work with Jenkins' release build ## How was this patch tested? manually You can merge this pull request into a Git repository by running: $ git pull https://github.com/felixcheung/spark releasescript Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/19754.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19754 commit e51029fef5b0359d71f56703e30fdc8acc43cc79 Author: Felix Cheung Date: 2017-11-14T10:42:15Z svn commit b860375d187f8560fefbb8ce394cf124a239ae0b Author: Felix Cheung Date: 2017-11-15T05:40:32Z fix repo publish --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
