[GitHub] spark pull request #19809: [SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 t...

[vinodkc]

Github user vinodkc closed the pull request at:

https://github.com/apache/spark/pull/19809


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19809: [SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 t...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/19809#discussion_r152923012
  
--- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -700,12 +700,7 @@ class VersionsSuite extends SparkFunSuite with Logging 
{
 
 test(s"$version: SPARK-17920: Insert into/overwrite avro table") {
--- End diff --

Ah, OK if there is a reason. I was just curious.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19809: [SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 t...

[vinodkc]

Github user vinodkc commented on a diff in the pull request:

https://github.com/apache/spark/pull/19809#discussion_r152922206
  
--- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -700,12 +700,7 @@ class VersionsSuite extends SparkFunSuite with Logging 
{
 
 test(s"$version: SPARK-17920: Insert into/overwrite avro table") {
--- End diff --

In master, this testcase uses an avro file & decimal schema from 
[https://github.com/apache/spark/pull/19003], but in branch-2.2  that  PR 19003 
is not backported. So I had to change the testcase in branch-2.2 to avoid using 
 schema & data added by PR 19003.
If we are fine to  backport  the PR 19003 in branch-2.2, same testcase in 
master can be used in branch-2.2 too. Please give your suggestions.



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19809: [SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 t...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/19809#discussion_r152916567
  
--- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -700,12 +700,7 @@ class VersionsSuite extends SparkFunSuite with Logging 
{
 
 test(s"$version: SPARK-17920: Insert into/overwrite avro table") {
--- End diff --

BTW, would you guys mind if I ask why the tests are different between 
master and branch-2.2? Just curious.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19809: [SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 t...

[vinodkc]

GitHub user vinodkc opened a pull request:

https://github.com/apache/spark/pull/19809

[SPARK-17920][SQL] [FOLLOWUP] Backport PR 19779 to branch-2.2

## What changes were proposed in this pull request?

A followup of 

> https://github.com/apache/spark/pull/19795

 , to simplify the file creation.

## How was this patch tested?

Only test case is updated


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vinodkc/spark 
br_FollowupSPARK-17920_branch-2.2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/19809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19809


commit 9cd03d38500f04d8d1ebf8771e79b1ba82d1f79b
Author: vinodkc 
Date:   2017-11-24T05:59:30Z

simplify the schema file creation in test




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org