[GitHub] spark pull request #19944: [SPARK-22756] [Build] [SparkR] Run SparkR tests i...

[gatorsmile]

Github user gatorsmile closed the pull request at:

https://github.com/apache/spark/pull/19944


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19944: [SPARK-22756] [Build] [SparkR] Run SparkR tests i...

[gatorsmile]

Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/19944#discussion_r156232118
  
--- Diff: dev/sparktestsupport/modules.py ---
@@ -481,7 +481,7 @@ def __hash__(self):
 
 sparkr = Module(
 name="sparkr",
-dependencies=[hive, mllib],
+dependencies=[hive, mllib, hive_thriftserver],
--- End diff --

Since SparkR already depends on hive, this PR just adds the dependence on 
`hive_thriftserver`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19944: [SPARK-22756] [Build] [SparkR] Run SparkR tests i...

[gatorsmile]

GitHub user gatorsmile opened a pull request:

https://github.com/apache/spark/pull/19944

[SPARK-22756] [Build] [SparkR] Run SparkR tests if hive_thriftserver module 
has code changes

## What changes were proposed in this pull request?
The recent PR change in hive_thriftserver caused the test failure in CRAN 
requirements. To some extends, SparkR module depends on hive_thriftserver 
module, so we should run hive_thriftserver tests if hive_thriftserver module 
has code changes.

## How was this patch tested?
N/A

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gatorsmile/spark addDepForR

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/19944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19944


commit 1fd2d53b66457b4b959efa73e69e65a287976b24
Author: gatorsmile 
Date:   2017-12-11T23:02:38Z

fix.




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org