[GitHub] spark pull request #20409: [SPARK-23233][PYTHON] Reset the cache in asNondet...

2018-01-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20409


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #20409: [SPARK-23233][PYTHON] Reset the cache in asNondet...

2018-01-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/20409#discussion_r164242518
  
--- Diff: python/pyspark/sql/udf.py ---
@@ -188,6 +188,9 @@ def asNondeterministic(self):
 
 .. versionadded:: 2.3
 """
+# Here, we explicitly clean the cache to create a JVM UDF instance
+# with 'deterministic' updated. See SPARK-23233.
+self._judf_placeholder = None
--- End diff --

Do you mean the reproducer above?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #20409: [SPARK-23233][PYTHON] Reset the cache in asNondet...

2018-01-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/20409#discussion_r164178516
  
--- Diff: python/pyspark/sql/udf.py ---
@@ -188,6 +188,9 @@ def asNondeterministic(self):
 
 .. versionadded:: 2.3
 """
+# Here, we explicitly clean the cache to create a JVM UDF instance
+# with 'deterministic' updated. See SPARK-23233.
+self._judf_placeholder = None
--- End diff --

Add a test case?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org