[GitHub] spark pull request #20510: [SPARK-23336][BUILD] Upgrade snappy-java to 1.1.4

[kiszk]

Github user kiszk commented on a diff in the pull request:

https://github.com/apache/spark/pull/20510#discussion_r166044370
  
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -182,7 +182,7 @@ slf4j-api-1.7.16.jar
 slf4j-log4j12-1.7.16.jar
 snakeyaml-1.15.jar
 snappy-0.2.jar
-snappy-java-1.1.2.6.jar
+snappy-java-1.1.4.jar
--- End diff --

+1


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20510: [SPARK-23336][BUILD] Upgrade snappy-java to 1.1.4

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/20510#discussion_r166030499
  
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -182,7 +182,7 @@ slf4j-api-1.7.16.jar
 slf4j-log4j12-1.7.16.jar
 snakeyaml-1.15.jar
 snappy-0.2.jar
-snappy-java-1.1.2.6.jar
+snappy-java-1.1.4.jar
--- End diff --

Is there any reason to use `1.1.4` instead of `1.1.7.1`?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20510: [SPARK-23336][BUILD] Upgrade snappy-java to 1.1.4

[wangyum]

GitHub user wangyum opened a pull request:

https://github.com/apache/spark/pull/20510

[SPARK-23336][BUILD] Upgrade snappy-java to 1.1.4

## What changes were proposed in this pull request?

This PR upgrade snappy-java to 1.1.4. release notes: 

- Fix a 1% performance regression when snappy is used in PIE executables.
- Improve compression performance by 5%.
- Improve decompression performance by 20%.

More details:

https://github.com/xerial/snappy-java/blob/master/Milestone.md#snappy-java-114-2017-05-22

## How was this patch tested?

manual tests


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wangyum/spark SPARK-23336

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20510.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20510


commit 1055afc107b0c2357449ae3f23bda089480579d9
Author: Yuming Wang 
Date:   2018-02-05T11:59:47Z

Upgrade snappy-java to 1.1.4




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org