[GitHub] spark pull request #20794: [SPARK-23644][CORE][UI] Use absolute path for RES...

2018-03-16 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20794


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #20794: [SPARK-23644][CORE][UI] Use absolute path for RES...

2018-03-10 Thread mgaido91
GitHub user mgaido91 opened a pull request:

https://github.com/apache/spark/pull/20794

[SPARK-23644][CORE][UI] Use absolute path for REST call in SHS

## What changes were proposed in this pull request?

SHS is using a relative path for the REST API call to get the list of the 
application is a relative path call. In case of the SHS being consumed through 
a proxy, it can be an issue if the path doesn't end with a "/".

Therefore, we should use an absolute path for the REST call as it is done 
for all the other resources.

## How was this patch tested?

manual tests
Before the change:
![screen shot 2018-03-10 at 4 22 02 
pm](https://user-images.githubusercontent.com/8821783/37244190-8ccf9d40-2485-11e8-8fa9-345bc81472fc.png)

After the change:
![screen shot 2018-03-10 at 4 36 34 pm 
1](https://user-images.githubusercontent.com/8821783/37244201-a1922810-2485-11e8-8856-eeab2bf5e180.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgaido91/spark SPARK-23644

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20794.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20794


commit 17ea399162167092e0362f90b49a03397ae82afe
Author: Marco Gaido 
Date:   2018-03-10T15:49:52Z

[SPARK-23644][CORE][UI] Use absolute path for REST call in SHS




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org