[GitHub] spark pull request #20895: [SPARK-23787][tests] Fix file download test in Sp...

2018-03-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20895


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #20895: [SPARK-23787][tests] Fix file download test in Sp...

2018-03-23 Thread vanzin
GitHub user vanzin opened a pull request:

https://github.com/apache/spark/pull/20895

[SPARK-23787][tests] Fix file download test in SparkSubmitSuite for Hadoop 
2.9.

This particular test assumed that Hadoop libraries did not support
http as a file system. Hadoop 2.9 does, so the test failed. The test
now forces a non-existent implementation for the http fs, which
forces the expected error.

There were also a couple of other issues in the same test: SparkSubmit
arguments in the wrong order, and the wrong check later when asserting,
which was being masked by the previous issues.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vanzin/spark SPARK-23787

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20895.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20895


commit 80b84ac66b1647f2b2b2191a8cf516574c519474
Author: Marcelo Vanzin 
Date:   2018-03-23T22:24:39Z

[SPARK-23787][tests] Fix file download test in SparkSubmitSuite for Hadoop 
2.9.

This particular test assumed that Hadoop libraries did not support
http as a file system. Hadoop 2.9 does, so the test failed. The test
now forces a non-existent implementation for the http fs, which
forces the expected error.

There were also a couple of other issues in the same test: SparkSubmit
arguments in the wrong order, and the wrong check later when asserting,
which was being masked by the previous issues.




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org