[GitHub] spark pull request #21163: [SPARK-24097][ML] Instruments improvements - Rand...

[jkbradley]

Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/21163#discussion_r185628460
  
--- Diff: 
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -22,12 +22,11 @@ import java.io.IOException
 import scala.collection.mutable
 import scala.util.Random
 
-import org.apache.spark.internal.Logging
 import org.apache.spark.ml.classification.DecisionTreeClassificationModel
 import org.apache.spark.ml.feature.LabeledPoint
 import org.apache.spark.ml.regression.DecisionTreeRegressionModel
 import org.apache.spark.ml.tree._
-import org.apache.spark.ml.util.Instrumentation
+import org.apache.spark.ml.util.{Instrumentation, OptionalInstrumentation}
--- End diff --

Instrumentation is no longer needed


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21163: [SPARK-24097][ML] Instruments improvements - Rand...

[WeichenXu123]

GitHub user WeichenXu123 opened a pull request:

https://github.com/apache/spark/pull/21163

[SPARK-24097][ML] Instruments improvements - RandomForest and 
GradientBoostedTree

## What changes were proposed in this pull request?

Instruments improvements for `RandomForest` and `GradientBoostedTree` in 
`ml.tree.impl` package.
**Note:** I add `Instrumentation` and `OptionalInstrumentation` with 
`Serializable`. Because tree algos need to ouput some logs on executor side and 
the instrumentation object need to be broadcast.

## How was this patch tested?

Manual.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/WeichenXu123/spark instr_rf_gbt

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/21163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #21163


commit cd5ea88687b72335647d74c0aeef375de01724d9
Author: WeichenXu 
Date:   2018-04-26T04:59:18Z

init pr




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org