[GitHub] spark pull request #21605: [SPARK-24385][SQL] Resolve self-join condition am...

2018-07-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/21605


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #21605: [SPARK-24385][SQL] Resolve self-join condition am...

2018-06-21 Thread mgaido91
GitHub user mgaido91 opened a pull request:

https://github.com/apache/spark/pull/21605

[SPARK-24385][SQL] Resolve self-join condition ambiguity for EqualNullSafe

## What changes were proposed in this pull request?

In Dataset.join we have a small hack for resolving ambiguity in the column 
name for self-joins. The current code supports only `EqualTo`.

The PR extends the fix to `EqualNullSafe`.

Credit for this PR should be given to @daniel-shields.

## How was this patch tested?

added UT


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgaido91/spark SPARK-24385_2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/21605.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #21605






---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org