[GitHub] spark pull request #21666: [SPARK-24535][SPARKR] fix tests on java check err...

2018-07-06 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/21666


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21666: [SPARK-24535][SPARKR] fix tests on java check err...

2018-07-03 Thread felixcheung 
Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/21666#discussion_r199713355
  
--- Diff: R/pkg/R/client.R ---
@@ -61,6 +61,11 @@ generateSparkSubmitArgs <- function(args, sparkHome, 
jars, sparkSubmitOpts, pack
 }
 
 checkJavaVersion <- function() {
+  if (is_windows()) {
+# See SPARK-24535
--- End diff --

updated


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21666: [SPARK-24535][SPARKR] fix tests on java check err...

2018-06-29 Thread felixcheung 
Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/21666#discussion_r199313370
  
--- Diff: R/pkg/R/client.R ---
@@ -61,6 +61,11 @@ generateSparkSubmitArgs <- function(args, sparkHome, 
jars, sparkSubmitOpts, pack
 }
 
 checkJavaVersion <- function() {
+  if (is_windows()) {
+# See SPARK-24535
--- End diff --

it would - I guess we need to root cause the reason why checkJavaVersion() 
fails on Windows/jdk 8 - otherwise sparkR.session() would just fail and no way 
to continue.



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21666: [SPARK-24535][SPARKR] fix tests on java check err...

2018-06-29 Thread shivaram 
Github user shivaram commented on a diff in the pull request:

https://github.com/apache/spark/pull/21666#discussion_r199224949
  
--- Diff: R/pkg/R/client.R ---
@@ -61,6 +61,11 @@ generateSparkSubmitArgs <- function(args, sparkHome, 
jars, sparkSubmitOpts, pack
 }
 
 checkJavaVersion <- function() {
+  if (is_windows()) {
+# See SPARK-24535
--- End diff --

But this just would end up skipping all tests on Windows ? I'm not sure if 
thats the right move here. Is there some way to run some tests on Windows ?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21666: [SPARK-24535][SPARKR] fix tests on java check err...

2018-06-29 Thread felixcheung 
GitHub user felixcheung opened a pull request:

https://github.com/apache/spark/pull/21666

[SPARK-24535][SPARKR] fix tests on java check error

## What changes were proposed in this pull request?


## How was this patch tested?

unit test, manual

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/felixcheung/spark rjavaskip

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/21666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #21666


commit 6560e85dd46c677460b9879a75ec420c450542e6
Author: Felix Cheung 
Date:   2018-06-29T05:12:32Z

skip cran check test on windows or java version fail

commit 35ab8a2359cd51b5daa4207d1067c7846ea6d249
Author: Felix Cheung 
Date:   2018-06-29T05:13:58Z

fix




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org