[GitHub] spark pull request #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix l...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21801 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix l...
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21801#discussion_r203249250 --- Diff: external/avro/src/test/resources/log4j.properties --- @@ -46,4 +46,4 @@ log4j.additivity.org.apache.hadoop.hive.metastore.RetryingHMSHandler=false log4j.logger.org.apache.hadoop.hive.metastore.RetryingHMSHandler=OFF log4j.additivity.hive.ql.metadata.Hive=false -log4j.logger.hive.ql.metadata.Hive=OFF \ No newline at end of file +log4j.logger.hive.ql.metadata.Hive=OFF --- End diff -- Me neither, actually. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix l...
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21801#discussion_r203248740 --- Diff: external/avro/src/test/resources/log4j.properties --- @@ -46,4 +46,4 @@ log4j.additivity.org.apache.hadoop.hive.metastore.RetryingHMSHandler=false log4j.logger.org.apache.hadoop.hive.metastore.RetryingHMSHandler=OFF log4j.additivity.hive.ql.metadata.Hive=false -log4j.logger.hive.ql.metadata.Hive=OFF \ No newline at end of file +log4j.logger.hive.ql.metadata.Hive=OFF --- End diff -- hm I didn't know Maven's checkstyle checks resources too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix l...
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/21801
[SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-java and Scala 2.12
build.
## What changes were proposed in this pull request?
This pr fixes lint-java and Scala 2.12 build.
lint-java:
```
[ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile:
File does not end with a newline.
```
Scala 2.12 build:
```
[error]
/.../sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousCoalesceRDD.scala:121:
overloaded method value addTaskCompletionListener with alternatives:
[error] (f: org.apache.spark.TaskContext =>
Unit)org.apache.spark.TaskContext
[error] (listener:
org.apache.spark.util.TaskCompletionListener)org.apache.spark.TaskContext
[error] cannot be applied to (org.apache.spark.TaskContext =>
java.util.List[Runnable])
[error] context.addTaskCompletionListener { ctx =>
[error] ^
```
## How was this patch tested?
Manually executed lint-java and Scala 2.12 build in my local environment.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ueshin/apache-spark
issues/SPARK-24386_24768/fix_build
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21801.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21801
commit 2fed7d487d90da5ea65d35d50208f88b5f829145
Author: Takuya UESHIN
Date: 2018-07-17T09:51:01Z
Fix lint-java.
commit 7f78d750411a4098527b2b332495f5dd4f20c63e
Author: Takuya UESHIN
Date: 2018-07-18T03:45:34Z
Fix Scala 2.12 build.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
